Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1759)

Unified Diff: test/mjsunit/regress/regress-4815.js

Issue 2090723005: [builtins] New frame type for exits to C++ builtins (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add missing condition in SafeStackFrameIter::frame() Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/message/paren_in_arg_string.out ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/regress/regress-4815.js
diff --git a/test/mjsunit/regress/regress-4815.js b/test/mjsunit/regress/regress-4815.js
index 00e61cb70a078f71e8fba7788ed702492f70095d..e44bde7d21f2db63b637fafaebe9f0d34764ca6b 100644
--- a/test/mjsunit/regress/regress-4815.js
+++ b/test/mjsunit/regress/regress-4815.js
@@ -19,12 +19,19 @@ function testTraceNativeConversion(nativeFunc) {
testTraceNativeConversion(Math.max);
testTraceNativeConversion(Math.min);
-function testBuiltinInStackTrace(script, nativeFuncName) {
+// C++ builtins.
+testTraceNativeConversion(Math.acos);
+testTraceNativeConversion(Math.asin);
+testTraceNativeConversion(Math.fround);
+testTraceNativeConversion(Math.imul);
+
+
+function testBuiltinInStackTrace(script, expectedString) {
try {
eval(script);
- assertUnreachable(nativeFuncName);
+ assertUnreachable(expectedString);
} catch (e) {
- assertTrue(e.stack.indexOf(nativeFuncName) >= 0, nativeFuncName);
+ assertTrue(e.stack.indexOf(expectedString) >= 0, expectedString);
}
}
@@ -32,7 +39,12 @@ function testBuiltinInStackTrace(script, nativeFuncName) {
// results when the method name is mentioned in the error message itself.
// This occurs, e.g., for Date.prototype.getYear, which uses a different code
// path and never hits the Generate_DatePrototype_GetField builtin.
-testBuiltinInStackTrace("Date.prototype.getDate.call('')", "String.getDate");
+testBuiltinInStackTrace("Date.prototype.getDate.call('')", "at String.getDate");
testBuiltinInStackTrace("Date.prototype.getUTCDate.call('')",
- "String.getUTCDate");
-testBuiltinInStackTrace("Date.prototype.getTime.call('')", "String.getTime");
+ "at String.getUTCDate");
+testBuiltinInStackTrace("Date.prototype.getTime.call('')", "at String.getTime");
+
+// C++ builtins.
+testBuiltinInStackTrace("Boolean.prototype.toString.call(thrower);",
+ "at toString");
+testBuiltinInStackTrace("new Date(thrower);", "at Date");
« no previous file with comments | « test/message/paren_in_arg_string.out ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698