Small: Use WebBase64/UrlBase64 encoding for requests sent to the server.

Use WebBase64/UrlBase64 encoding for requests sent to the server.

BUG=543161, 620874
Committed: https://crrev.com/902ddfefc285ceef7284d907b6a5611ebb9852e4
Cr-Commit-Position: refs/heads/master@{#402715}

[vakh (use Gerrit instead), 2016-06-22 16:42:21]

vakh@chromium.org changed reviewers:
+ awoz@chromium.org, nparker@chromium.org

[vakh (use Gerrit instead), 2016-06-22 16:42:22]

nparker@, awoz@: Please review this small change.

[Nathan Parker, 2016-06-22 17:24:06]

lgtm

https://codereview.chromium.org/2090593003/diff/1/components/safe_browsing_db...
File components/safe_browsing_db/v4_update_protocol_manager.cc (right):

https://codereview.chromium.org/2090593003/diff/1/components/safe_browsing_db...
components/safe_browsing_db/v4_update_protocol_manager.cc:194: // static
nit: I feel like the longer name doesn't add much value -- if you want to know
the details of how it's encoded, you should read the code or the function
comments.

https://codereview.chromium.org/2090593003/diff/1/components/safe_browsing_db...
components/safe_browsing_db/v4_update_protocol_manager.cc:217:
base::Base64UrlEncode(req_data, base::Base64UrlEncodePolicy::INCLUDE_PADDING,
Does this affect any test?  Should it?

[vakh (use Gerrit instead), 2016-06-22 20:50:44]

Update get_hash_manager to use Url encoding. Add a test.

[vakh (use Gerrit instead), 2016-06-22 20:57:03]

Thanks for the review, nparker@

https://codereview.chromium.org/2090593003/diff/1/components/safe_browsing_db...
File components/safe_browsing_db/v4_update_protocol_manager.cc (right):

https://codereview.chromium.org/2090593003/diff/1/components/safe_browsing_db...
components/safe_browsing_db/v4_update_protocol_manager.cc:194: // static
On 2016/06/22 17:24:05, Nathan Parker wrote:
> nit: I feel like the longer name doesn't add much value -- if you want to know
> the details of how it's encoded, you should read the code or the function
> comments.

Done.

https://codereview.chromium.org/2090593003/diff/1/components/safe_browsing_db...
components/safe_browsing_db/v4_update_protocol_manager.cc:217:
base::Base64UrlEncode(req_data, base::Base64UrlEncodePolicy::INCLUDE_PADDING,
On 2016/06/22 17:24:05, Nathan Parker wrote:
> Does this affect any test?  Should it?

Done.
Added a test for the '-' and for the '_' cases.

[vakh (use Gerrit instead), 2016-06-29 00:11:19]

git pull

[vakh (use Gerrit instead), 2016-06-29 04:20:28]

The CQ bit was checked by vakh@chromium.org

[vakh (use Gerrit instead), 2016-06-29 04:20:29]

The patchset sent to the CQ was uploaded after l-g-t-m from nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/2090593003/#ps40001
(title: "git pull")

[commit-bot: I haz the power, 2016-06-29 04:21:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 04:27:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-29 04:30:50]

Description was changed from

==========
Use WebBase64/UrlBase64 encoding for requests sent to the server.

BUG=543161, 620874
==========

to

==========
Use WebBase64/UrlBase64 encoding for requests sent to the server.

BUG=543161, 620874

Committed: https://crrev.com/902ddfefc285ceef7284d907b6a5611ebb9852e4
Cr-Commit-Position: refs/heads/master@{#402715}
==========

[commit-bot: I haz the power, 2016-06-29 04:30:51]

Patchset 3 (id:??) landed as
https://crrev.com/902ddfefc285ceef7284d907b6a5611ebb9852e4
Cr-Commit-Position: refs/heads/master@{#402715}