components/safe_browsing_db/v4_update_protocol_manager.cc - Issue 2090593003: Small: Use WebBase64/UrlBase64 encoding for requests sent to the server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_update_protocol_manager.cc

Issue 2090593003: Small: Use WebBase64/UrlBase64 encoding for requests sent to the server. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@01_UpdateDbAndStores

Patch Set: git pull Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/safe_browsing_db/v4_update_protocol_manager.h ('k') | components/safe_browsing_db/v4_update_protocol_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing_db/v4_update_protocol_manager.cc

diff --git a/components/safe_browsing_db/v4_update_protocol_manager.cc b/components/safe_browsing_db/v4_update_protocol_manager.cc

index 23617f319f3286c8334a0a2f4afe3accb52a4515..a67c4071110dee3e88a72ac19f65f985539b751c 100644

--- a/components/safe_browsing_db/v4_update_protocol_manager.cc

+++ b/components/safe_browsing_db/v4_update_protocol_manager.cc

@@ -6,7 +6,7 @@

#include <utility>

-#include "base/base64.h"

+#include "base/base64url.h"

#include "base/macros.h"

#include "base/metrics/histogram_macros.h"

#include "base/rand_util.h"

@@ -215,8 +215,8 @@ std::string V4UpdateProtocolManager::GetBase64SerializedUpdateRequestProto(

// Serialize and Base64 encode.

std::string req_data, req_base64;

request.SerializeToString(&req_data);

- base::Base64Encode(req_data, &req_base64);

+ base::Base64UrlEncode(req_data, base::Base64UrlEncodePolicy::INCLUDE_PADDING,

+ &req_base64);

return req_base64;

}