components/safe_browsing_db/v4_update_protocol_manager.h - Issue 2090593003: Small: Use WebBase64/UrlBase64 encoding for requests sent to the server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_update_protocol_manager.h

Issue 2090593003: Small: Use WebBase64/UrlBase64 encoding for requests sent to the server. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@01_UpdateDbAndStores

Patch Set: git pull Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/safe_browsing_db/v4_get_hash_protocol_manager.cc ('k') | components/safe_browsing_db/v4_update_protocol_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing_db/v4_update_protocol_manager.h

diff --git a/components/safe_browsing_db/v4_update_protocol_manager.h b/components/safe_browsing_db/v4_update_protocol_manager.h

index 1439cc65900af85b1a5eaf2067449405afff3ecd..20f18ee893b485e6fd2ca2bbe147210f275dbd18 100644

--- a/components/safe_browsing_db/v4_update_protocol_manager.h

+++ b/components/safe_browsing_db/v4_update_protocol_manager.h

@@ -85,6 +85,8 @@ class V4UpdateProtocolManager : public net::URLFetcherDelegate,

FRIEND_TEST_ALL_PREFIXES(V4UpdateProtocolManagerTest, TestGetUpdatesNoError);

FRIEND_TEST_ALL_PREFIXES(V4UpdateProtocolManagerTest,

TestGetUpdatesWithOneBackoff);

+ FRIEND_TEST_ALL_PREFIXES(V4UpdateProtocolManagerTest,

+ TestBase64EncodingUsesUrlEncoding);

friend class V4UpdateProtocolManagerFactoryImpl;

// The method to populate |gurl| with the URL to be sent to the server.

@@ -96,7 +98,7 @@ class V4UpdateProtocolManager : public net::URLFetcherDelegate,

net::HttpRequestHeaders* headers) const;

// Fills a FetchThreatListUpdatesRequest protocol buffer for a request.

- // Returns the serialized and base 64 encoded request as a string.

+ // Returns the serialized and base64 URL encoded request as a string.

static std::string GetBase64SerializedUpdateRequestProto(

const StoreStateMap& store_state_map);