Small: Use WebBase64/UrlBase64 encoding for requests sent to the server.

components/safe_browsing_db/v4_update_protocol_manager_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/safe_browsing_db/v4_update_protocol_manager.h"
 
 #include <memory>
 #include <vector>
 
 #include "base/base64.h"
@@ skipping 280 matching lines @@
   fetcher->set_response_code(net::HTTP_OK);
   fetcher->SetResponseString(GetExpectedV4UpdateResponse(expected_lurs));
   fetcher->delegate()->OnURLFetchComplete(fetcher);
 
   // No error, back off multiplier is unchanged.
   EXPECT_EQ(0ul, pm->update_error_count_);
   EXPECT_EQ(1ul, pm->update_back_off_mult_);
   EXPECT_FALSE(pm->IsUpdateScheduled());
 }
 
+TEST_F(V4UpdateProtocolManagerTest, TestBase64EncodingUsesUrlEncoding) {
+  // NOTE(vakh): I handpicked this value for state by generating random strings
+  // and picked the one that leads to a '-' in the base64 url encoded request
+  // output.
+  std::string state_minus = "z-R~3ruViQH";
+  StoreStateMap store_state_map_minus{
+      {UpdateListIdentifier(LINUX_PLATFORM, URL, MALWARE_THREAT), state_minus}};
+  std::string encoded_request_with_minus =
+      V4UpdateProtocolManager::GetBase64SerializedUpdateRequestProto(
+          store_state_map_minus);
+  EXPECT_EQ("GhMIARACGgt6LVJ-M3J1VmlRSCgB", encoded_request_with_minus);
+
+  // NOTE(vakh): Same process for chosing this string. I am representing it
+  // in base64 encoded form because the actual state value contains non-ASCII
+  // characters.
+  std::string base64_encoded_state_underscore = "VTFfITBf4lBM";
+  std::string state_underscore;
+  base::Base64Decode(base64_encoded_state_underscore, &state_underscore);
+  StoreStateMap store_state_map_underscore{
+      {UpdateListIdentifier(LINUX_PLATFORM, URL, MALWARE_THREAT),
+       state_underscore}};
+  std::string encoded_request_with_underscore =
+      V4UpdateProtocolManager::GetBase64SerializedUpdateRequestProto(
+          store_state_map_underscore);
+  EXPECT_EQ("GhEIARACGglVMV8hMF_iUEwoAQ==", encoded_request_with_underscore);
+}
+
 }  // namespace safe_browsing