Use instance type in Object::IsErrorObject().

Use JS_ERROR_TYPE to check for error objects.

Replace explicit Object::IsErrorObject() and v8::IsNativeError() with macro generated functions Object::IsJSError() and HeapObject::IsJSError().

BUG=

Committed: https://crrev.com/90e4fd136387ca7271d8ea87f4fc667e4f55063b
Cr-Commit-Position: refs/heads/master@{#37244}
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Committed: https://crrev.com/a2dad04f9c0931f8c120cc6457de862866297897
Cr-Commit-Position: refs/heads/master@{#37279}

[Franzi, 2016-06-23 12:01:25]

franzih@chromium.org changed reviewers:
+ verwaest@chromium.org

[Franzi, 2016-06-23 12:01:25]

Hi Toon, 

I changed Object::IsErrorObject() to simply check the instance type.

Cheers, 

Franzi

[Toon Verwaest, 2016-06-23 12:04:39]

That was quick! lgtm. (api.cc remaining though)

https://codereview.chromium.org/2090333002/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2090333002/diff/20001/src/objects.cc#newcode1294
src/objects.cc:1294: Handle<JSReceiver> receiver =
Handle<JSReceiver>::cast(object);
since you know it's a JSObject, you might as well cast to that :)

[Franzi, 2016-06-23 14:00:46]

Description was changed from

==========
Use instance type in Object::IsErrorObject().

BUG=
==========

to

==========
Use JS_ERROR_TYPE to check for error objects.

BUG=
==========

[Franzi, 2016-06-23 14:10:19]

Simplified IsNativeError() as well. PTAL.

Thanks, 

Franzi

https://codereview.chromium.org/2090333002/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2090333002/diff/20001/src/objects.cc#newcode1294
src/objects.cc:1294: Handle<JSReceiver> receiver =
Handle<JSReceiver>::cast(object);
On 2016/06/23 12:04:39, Toon Verwaest wrote:
> since you know it's a JSObject, you might as well cast to that :)

Done.

[Toon Verwaest, 2016-06-23 14:22:40]

https://codereview.chromium.org/2090333002/diff/60001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2090333002/diff/60001/src/objects.cc#newcode1292
src/objects.cc:1292: bool Object::IsErrorObject(Isolate* isolate, Handle<Object>
object) {
This doesn't need the isolate anymore.

What about doing:
Object::IsErrorObject() {
  return IsHeapObject() && HeapObject::cast(this)->IsErrorObject()
}
HeapObject::IsErrorObject() {
  return map()->instance_type() == JS_ERROR_TYPE;
}

and just calling IsErrorObject in api.cc?

[jochen (gone - plz use gerrit), 2016-06-23 14:42:15]

jochen@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-06-23 14:42:15]

https://codereview.chromium.org/2090333002/diff/60001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2090333002/diff/60001/src/api.cc#newcode3011
src/api.cc:3011: return js_obj->map()->instance_type() == i::JS_ERROR_TYPE;
why not just 

auto self = Utils::OpenHandle(this);
return i::Object::IsErrorObject(self);

[Toon Verwaest, 2016-06-23 17:09:30]

lgtm with a last comment

https://codereview.chromium.org/2090333002/diff/80001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2090333002/diff/80001/src/objects.cc#newcode1292
src/objects.cc:1292: bool Object::IsErrorObject(Handle<Object> object) {
This doesn't need to be a static method anymore. You can just do IsHeapObject()
&& HeapObject::cast(this)->IsJSError() ... :)

[Franzi, 2016-06-24 08:39:40]

PTAL. Thanks, 

Franzi

[Franzi, 2016-06-24 09:27:45]

Us macro-generated IsJSError() and TYPE_CHECKER() instead of explicit definition

[Franzi, 2016-06-24 09:29:50]

Description was changed from

==========
Use JS_ERROR_TYPE to check for error objects.

BUG=
==========

to

==========
Use JS_ERROR_TYPE to check for error objects.

Replace explicit Object::IsErrorObject() with macro generated functions
Object::IsJSError() and HeapObject::IsJSError().

BUG=
==========

[Toon Verwaest, 2016-06-24 09:30:47]

lgtm

[Franzi, 2016-06-24 09:37:01]

The CQ bit was checked by franzih@chromium.org

[commit-bot: I haz the power, 2016-06-24 09:37:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2090333002/160001

[commit-bot: I haz the power, 2016-06-24 09:52:53]

Description was changed from

==========
Use JS_ERROR_TYPE to check for error objects.

Replace explicit Object::IsErrorObject() with macro generated functions
Object::IsJSError() and HeapObject::IsJSError().

BUG=
==========

to

==========
Use JS_ERROR_TYPE to check for error objects.

Replace explicit Object::IsErrorObject() with macro generated functions
Object::IsJSError() and HeapObject::IsJSError().

BUG=
==========

[commit-bot: I haz the power, 2016-06-24 09:52:54]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-06-24 09:53:24]

Description was changed from

==========
Use JS_ERROR_TYPE to check for error objects.

Replace explicit Object::IsErrorObject() with macro generated functions
Object::IsJSError() and HeapObject::IsJSError().

BUG=
==========

to

==========
Use JS_ERROR_TYPE to check for error objects.

Replace explicit Object::IsErrorObject() with macro generated functions
Object::IsJSError() and HeapObject::IsJSError().

BUG=

Committed: https://crrev.com/90e4fd136387ca7271d8ea87f4fc667e4f55063b
Cr-Commit-Position: refs/heads/master@{#37244}
==========

[commit-bot: I haz the power, 2016-06-24 09:53:25]

Patchset 9 (id:??) landed as
https://crrev.com/90e4fd136387ca7271d8ea87f4fc667e4f55063b
Cr-Commit-Position: refs/heads/master@{#37244}

[Michael Achenbach, 2016-06-24 11:52:08]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/2092083002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...

Please rebase upstream first if intended..

[Franzi, 2016-06-24 13:43:10]

Description was changed from

==========
Use JS_ERROR_TYPE to check for error objects.

Replace explicit Object::IsErrorObject() with macro generated functions
Object::IsJSError() and HeapObject::IsJSError().

BUG=

Committed: https://crrev.com/90e4fd136387ca7271d8ea87f4fc667e4f55063b
Cr-Commit-Position: refs/heads/master@{#37244}
==========

to

==========
Use JS_ERROR_TYPE to check for error objects.

Replace explicit Object::IsErrorObject() with macro generated functions
Object::IsJSError() and HeapObject::IsJSError().

BUG=

Committed: https://crrev.com/90e4fd136387ca7271d8ea87f4fc667e4f55063b
Cr-Commit-Position: refs/heads/master@{#37244}
==========

[Franzi, 2016-06-27 06:46:11]

Description was changed from

==========
Use JS_ERROR_TYPE to check for error objects.

Replace explicit Object::IsErrorObject() with macro generated functions
Object::IsJSError() and HeapObject::IsJSError().

BUG=

Committed: https://crrev.com/90e4fd136387ca7271d8ea87f4fc667e4f55063b
Cr-Commit-Position: refs/heads/master@{#37244}
==========

to

==========
Use JS_ERROR_TYPE to check for error objects.

Replace explicit Object::IsErrorObject() with macro generated functions
Object::IsJSError() and HeapObject::IsJSError().

BUG=

Committed: https://crrev.com/90e4fd136387ca7271d8ea87f4fc667e4f55063b
Cr-Commit-Position: refs/heads/master@{#37244}
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

[Franzi, 2016-06-27 06:46:57]

Description was changed from

==========
Use JS_ERROR_TYPE to check for error objects.

Replace explicit Object::IsErrorObject() with macro generated functions
Object::IsJSError() and HeapObject::IsJSError().

BUG=

Committed: https://crrev.com/90e4fd136387ca7271d8ea87f4fc667e4f55063b
Cr-Commit-Position: refs/heads/master@{#37244}
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

to

==========
Use JS_ERROR_TYPE to check for error objects.

Replace explicit Object::IsErrorObject() and v8::IsNativeError() with macro
generated functions Object::IsJSError() and HeapObject::IsJSError().

BUG=

Committed: https://crrev.com/90e4fd136387ca7271d8ea87f4fc667e4f55063b
Cr-Commit-Position: refs/heads/master@{#37244}
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

[Franzi, 2016-06-27 08:08:13]

The CQ bit was checked by franzih@chromium.org

[Franzi, 2016-06-27 08:08:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2090333002/#ps180001
(title: "Rebase")

[commit-bot: I haz the power, 2016-06-27 08:08:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 09:32:05]

Description was changed from

==========
Use JS_ERROR_TYPE to check for error objects.

Replace explicit Object::IsErrorObject() and v8::IsNativeError() with macro
generated functions Object::IsJSError() and HeapObject::IsJSError().

BUG=

Committed: https://crrev.com/90e4fd136387ca7271d8ea87f4fc667e4f55063b
Cr-Commit-Position: refs/heads/master@{#37244}
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

to

==========
Use JS_ERROR_TYPE to check for error objects.

Replace explicit Object::IsErrorObject() and v8::IsNativeError() with macro
generated functions Object::IsJSError() and HeapObject::IsJSError().

BUG=

Committed: https://crrev.com/90e4fd136387ca7271d8ea87f4fc667e4f55063b
Cr-Commit-Position: refs/heads/master@{#37244}
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-06-27 09:32:07]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-06-27 09:34:50]

Description was changed from

==========
Use JS_ERROR_TYPE to check for error objects.

Replace explicit Object::IsErrorObject() and v8::IsNativeError() with macro
generated functions Object::IsJSError() and HeapObject::IsJSError().

BUG=

Committed: https://crrev.com/90e4fd136387ca7271d8ea87f4fc667e4f55063b
Cr-Commit-Position: refs/heads/master@{#37244}
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

to

==========
Use JS_ERROR_TYPE to check for error objects.

Replace explicit Object::IsErrorObject() and v8::IsNativeError() with macro
generated functions Object::IsJSError() and HeapObject::IsJSError().

BUG=

Committed: https://crrev.com/90e4fd136387ca7271d8ea87f4fc667e4f55063b
Cr-Commit-Position: refs/heads/master@{#37244}
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Committed: https://crrev.com/a2dad04f9c0931f8c120cc6457de862866297897
Cr-Commit-Position: refs/heads/master@{#37279}
==========

[commit-bot: I haz the power, 2016-06-27 09:34:51]

Patchset 10 (id:??) landed as
https://crrev.com/a2dad04f9c0931f8c120cc6457de862866297897
Cr-Commit-Position: refs/heads/master@{#37279}

[Franzi, 2016-08-02 08:18:52]

Patchset #11 (id:200001) has been deleted