Use instance type in Object.prototype.toString().

Refactor Object.prototype.toString() to use the instance type instead of class_name().
Now we can turn it into a turbofan stub.

Create new instance types JS_ARGUMENTS_TYPE and JS_ERROR_TYPE.

Committed: https://crrev.com/e9a93a9c2b9de0b05ea4dd53757c306d66cb00d3
Cr-Commit-Position: refs/heads/master@{#37219}

[Franzi, 2016-06-21 11:35:54]

Description was changed from

==========
WIP


Delete JSReceiver::BuiltinStringTag() and use fast strings


Start unittest that checks that all JS_Instance_types are handled.


Delete unused heap symbols


Include all types in switch case


Use JS_ARGUMENTS_TYPE in strict case as well (cherry picked from commit 02a8bed)


Rename function back to BuiltinStringTag() and move it around (cherry picked
from commit 6df4c54)


New instance type JS_ARGUMENTS_TYPE (cherry picked from commit b6d411c)


Check for errors in case JS_OBJECT_TYPE (cherry picked from commit 8a3412c)


For JS_VALUE_TYPE, use type of the value (cherry picked from commit 499ee55)


Fix global object case (cherry picked from commit df25d37)


return tag not bool (cherry picked from commit ef662a2)


Speed-up ObjectProtoToString() by using the instance type.

Use instance type to find toString() value where possible instead of
class_name().

BUG=

patch from issue 2049033003 at patchset 100001
(http://crrev.com/2049033003#ps100001)
(cherry picked from commit b71af45)

Remove double lines about Generator case


Remove empty lines


Delete comment


Fix toString() method on typed arrays


Support for Map/Set Iterator


Add support for Generator, ArrayBuffer, DataView, Maps, and Sets


Add tests
==========

to

==========
Refactor Object.prototype.toString() to use the instance type instead of
class_name(). Later we can turn it into a turbofan stub. 

Create new InstancenType JS_ARGUMENTS_TYPE.
==========

[Franzi, 2016-06-21 11:35:54]

franzih@chromium.org changed reviewers:
+ verwaest@chromium.org

[Franzi, 2016-06-23 09:51:00]

Description was changed from

==========
Refactor Object.prototype.toString() to use the instance type instead of
class_name(). Later we can turn it into a turbofan stub. 

Create new InstancenType JS_ARGUMENTS_TYPE.
==========

to

==========
Refactor Object.prototype.toString() to use the instance type instead of
class_name(). 
Then we can turn it into a turbofan stub. 

Create new instance types JS_ARGUMENTS_TYPE and JS_ERROR_TYPE.
==========

[Franzi, 2016-06-23 10:56:44]

Patchset #11 (id:200001) has been deleted

[Franzi, 2016-06-23 11:24:47]

Description was changed from

==========
Refactor Object.prototype.toString() to use the instance type instead of
class_name(). 
Then we can turn it into a turbofan stub. 

Create new instance types JS_ARGUMENTS_TYPE and JS_ERROR_TYPE.
==========

to

==========
Refactor Object.prototype.toString() to use the instance type instead of
class_name(). 
Now we can turn it into a turbofan stub. 

Create new instance types JS_ARGUMENTS_TYPE and JS_ERROR_TYPE.
==========

[Franzi, 2016-06-23 11:54:59]

Hi Toon, 

Here's ObjectProtoToString() that uses class_name() only for JS_API_OBJECT_TYPE.
Can you have a look? 

Thanks, 

Franzi

[Toon Verwaest, 2016-06-23 12:03:33]

nice, lgtm. Can you upload an additional CL that changes IsNativeError in api.cc
as well as the other variant in objects.cc to use the new instance types?

https://codereview.chromium.org/2080243003/diff/260001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2080243003/diff/260001/src/objects.cc#newcode...
src/objects.cc:15653: Maybe<bool> is_array = Object::IsArray(receiver);
Add comment that this order is observably wrong with TODO to fix the semantics.

[Franzi, 2016-06-23 14:07:07]

On 2016/06/23 12:03:33, Toon Verwaest wrote:
> nice, lgtm. Can you upload an additional CL that changes IsNativeError in
api.cc
> as well as the other variant in objects.cc to use the new instance types?
> 
> https://codereview.chromium.org/2080243003/diff/260001/src/objects.cc
> File src/objects.cc (right):
> 
>
https://codereview.chromium.org/2080243003/diff/260001/src/objects.cc#newcode...
> src/objects.cc:15653: Maybe<bool> is_array = Object::IsArray(receiver);
> Add comment that this order is observably wrong with TODO to fix the
semantics.

Added a TODO comment and uploaded a CL that uses JS_ERROR_TYPE when we check if 
an object is an error object.

[Franzi, 2016-06-23 14:07:28]

The CQ bit was checked by franzih@chromium.org

[Franzi, 2016-06-23 14:07:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2080243003/#ps150011
(title: "Add TODO comment about checking IsArray() before reading toStringTag.")

[commit-bot: I haz the power, 2016-06-23 14:07:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2080243003/150011

[commit-bot: I haz the power, 2016-06-23 14:11:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 14:11:08]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/17869)

[Franzi, 2016-06-23 14:17:59]

franzih@chromium.org changed reviewers:
+ jochen@chromium.org

[Franzi, 2016-06-23 14:18:00]

Hi Jochen, 

can I get an owner's lgtm for heap.cc and objects-visiting.cc?

Thanks, 

Franzi

https://codereview.chromium.org/2080243003/diff/260001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2080243003/diff/260001/src/objects.cc#newcode...
src/objects.cc:15653: Maybe<bool> is_array = Object::IsArray(receiver);
On 2016/06/23 12:03:33, Toon Verwaest wrote:
> Add comment that this order is observably wrong with TODO to fix the
semantics.

Done.

[jochen (gone - plz use gerrit), 2016-06-23 14:30:14]

lgtm

can you use the JS_ERROR_TYPE to speed up v8::Value::IsError() or whatever it's
called?

[Toon Verwaest, 2016-06-23 14:34:38]

Already done ;)

[Franzi, 2016-06-23 14:37:26]

The CQ bit was checked by franzih@chromium.org

[commit-bot: I haz the power, 2016-06-23 14:37:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2080243003/150011

[commit-bot: I haz the power, 2016-06-23 14:39:39]

Description was changed from

==========
Refactor Object.prototype.toString() to use the instance type instead of
class_name(). 
Now we can turn it into a turbofan stub. 

Create new instance types JS_ARGUMENTS_TYPE and JS_ERROR_TYPE.
==========

to

==========
Refactor Object.prototype.toString() to use the instance type instead of
class_name(). 
Now we can turn it into a turbofan stub. 

Create new instance types JS_ARGUMENTS_TYPE and JS_ERROR_TYPE.
==========

[commit-bot: I haz the power, 2016-06-23 14:39:40]

Committed patchset #14 (id:150011)

[commit-bot: I haz the power, 2016-06-23 14:40:59]

Description was changed from

==========
Refactor Object.prototype.toString() to use the instance type instead of
class_name(). 
Now we can turn it into a turbofan stub. 

Create new instance types JS_ARGUMENTS_TYPE and JS_ERROR_TYPE.
==========

to

==========
Refactor Object.prototype.toString() to use the instance type instead of
class_name().
Now we can turn it into a turbofan stub.

Create new instance types JS_ARGUMENTS_TYPE and JS_ERROR_TYPE.

Committed: https://crrev.com/e9a93a9c2b9de0b05ea4dd53757c306d66cb00d3
Cr-Commit-Position: refs/heads/master@{#37219}
==========

[commit-bot: I haz the power, 2016-06-23 14:41:00]

Patchset 14 (id:??) landed as
https://crrev.com/e9a93a9c2b9de0b05ea4dd53757c306d66cb00d3
Cr-Commit-Position: refs/heads/master@{#37219}