src/messages.cc - Issue 2090333002: Use instance type in Object::IsErrorObject().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.cc

Issue 2090333002: Use instance type in Object::IsErrorObject(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@RefactorToString

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/messages.cc

diff --git a/src/messages.cc b/src/messages.cc

index 2b0cdfc084d2ca1a666186b7caf71666df3ba05a..0dffbb4dab13ca5dc97e417634597118d048ca3f 100644

--- a/src/messages.cc

+++ b/src/messages.cc

@@ -98,7 +98,7 @@ void MessageHandler::ReportMessage(Isolate* isolate, MessageLocation* loc,

MaybeHandle<Object> maybe_stringified;

Handle<Object> stringified;

// Make sure we don't leak uncaught internally generated Error objects.

- if (Object::IsErrorObject(isolate, argument)) {

+ if (argument->IsJSError()) {

Handle<Object> args[] = {argument};

maybe_stringified = Execution::TryCall(

isolate, isolate->no_side_effects_to_string_fun(),

« no previous file with comments | « src/isolate.cc ('k') | src/objects.h » ('j') | no next file with comments »