Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2091243002: Use the instance type to determine if an object is a promise. (Closed)

Created:
4 years, 5 months ago by Franzi
Modified:
4 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@SimplifyIsError
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use the instance type to determine if an object is a promise. We can check if the instance type of an object is JS_PROMISE_TYPE to determine if it is a promise rather than test whether the property promise_state_symbol is present. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/a1debda6c79622d0b6b66437610aa28fb0c7af08 Cr-Commit-Position: refs/heads/master@{#37283}

Patch Set 1 #

Patch Set 2 : Use Macros #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -22 lines) Patch
M src/api.cc View 1 1 chunk +1 line, -6 lines 0 comments Download
M src/objects.h View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M src/objects.cc View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download
M src/objects-inl.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (14 generated)
Franzi
Hi Toon, I think we can simplify IsPromise() as well. Please take a look. Thanks, ...
4 years, 5 months ago (2016-06-24 10:26:32 UTC) #5
Toon Verwaest
Nice :) lgtm
4 years, 5 months ago (2016-06-24 11:55:22 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 2090333002 Patch 180001). Please resolve the dependency and ...
4 years, 5 months ago (2016-06-27 08:42:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2091243002/40001
4 years, 5 months ago (2016-06-27 09:33:44 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/3877)
4 years, 5 months ago (2016-06-27 09:35:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2091243002/60001
4 years, 5 months ago (2016-06-27 09:54:02 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-27 11:05:24 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 11:08:09 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a1debda6c79622d0b6b66437610aa28fb0c7af08
Cr-Commit-Position: refs/heads/master@{#37283}

Powered by Google App Engine
This is Rietveld 408576698