Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2089443002: Convert XFA_ELEMENT to an enum class (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Convert XFA_ELEMENT to an enum class This CL changes XFA_ELEMENT From an enum to an enum class. The type name was updated to XFA_Element. Committed: https://pdfium.googlesource.com/pdfium/+/56a8b1944d555ed65dda97164b702a9a657485ca

Patch Set 1 #

Patch Set 2 : Rebase to master #

Total comments: 2

Patch Set 3 : review cleanup #

Total comments: 2

Patch Set 4 : Rebase to master #

Patch Set 5 : More unknown checks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2298 lines, -2267 lines) Patch
M fpdfsdk/fsdk_annothandler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdoc.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdochandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffdocview.cpp View 10 chunks +27 lines, -25 lines 0 comments Download
M xfa/fxfa/app/xfa_fffield.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M xfa/fxfa/app/xfa_ffnotify.cpp View 9 chunks +36 lines, -36 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpageview.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_fftextedit.cpp View 10 chunks +13 lines, -13 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 3 chunks +15 lines, -15 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidgetacc.cpp View 23 chunks +64 lines, -64 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidgethandler.cpp View 10 chunks +49 lines, -47 lines 0 comments Download
M xfa/fxfa/include/fxfa_basic.h View 5 chunks +331 lines, -329 lines 0 comments Download
M xfa/fxfa/include/fxfa_widget.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/include/xfa_ffwidget.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/include/xfa_ffwidgethandler.h View 2 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxfa/parser/cxfa_assist.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_bind.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_box.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/cxfa_box.cpp View 4 chunks +7 lines, -6 lines 0 comments Download
M xfa/fxfa/parser/cxfa_calculate.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/cxfa_caption.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/cxfa_data.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_data.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cxfa_event.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_event.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M xfa/fxfa/parser/cxfa_fill.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_fill.cpp View 6 chunks +14 lines, -14 lines 0 comments Download
M xfa/fxfa/parser/cxfa_font.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cxfa_line.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_stroke.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cxfa_stroke.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/cxfa_validate.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M xfa/fxfa/parser/cxfa_value.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_value.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/cxfa_widgetdata.h View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/cxfa_widgetdata.cpp View 50 chunks +93 lines, -93 lines 0 comments Download
M xfa/fxfa/parser/xfa_basic_data.cpp View 1 2 3 chunks +797 lines, -791 lines 0 comments Download
M xfa/fxfa/parser/xfa_basic_imp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_basic_imp.cpp View 1 2 3 4 11 chunks +30 lines, -26 lines 0 comments Download
M xfa/fxfa/parser/xfa_document.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_datadescription_imp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_datadescription_imp.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.cpp View 47 chunks +123 lines, -123 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_imp.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_layout_imp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_serialize.cpp View 12 chunks +19 lines, -19 lines 0 comments Download
M xfa/fxfa/parser/xfa_layout_appadapter.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_appadapter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_itemlayout.cpp View 37 chunks +64 lines, -63 lines 0 comments Download
M xfa/fxfa/parser/xfa_layout_pagemgr_new.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_pagemgr_new.cpp View 59 chunks +95 lines, -93 lines 0 comments Download
M xfa/fxfa/parser/xfa_locale.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_locale.cpp View 3 chunks +29 lines, -25 lines 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/parser/xfa_object.h View 10 chunks +16 lines, -16 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 75 chunks +169 lines, -165 lines 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.cpp View 26 chunks +41 lines, -41 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_datawindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_eventpseudomodel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_layoutpseudomodel.cpp View 7 chunks +21 lines, -21 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_logpseudomodel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_nodehelper.h View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_nodehelper.cpp View 1 9 chunks +22 lines, -22 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_resolveprocessor.cpp View 1 8 chunks +13 lines, -13 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_signaturepseudomodel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_utils_imp.cpp View 4 chunks +92 lines, -91 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-06-20 19:33:18 UTC) #2
Lei Zhang
https://codereview.chromium.org/2089443002/diff/20001/xfa/fxfa/parser/xfa_basic_imp.cpp File xfa/fxfa/parser/xfa_basic_imp.cpp (right): https://codereview.chromium.org/2089443002/diff/20001/xfa/fxfa/parser/xfa_basic_imp.cpp#newcode198 xfa/fxfa/parser/xfa_basic_imp.cpp:198: return (static_cast<int32_t>(eName) < g_iXFAElementCount) Shouldn't this always eval to ...
4 years, 6 months ago (2016-06-20 21:43:16 UTC) #3
dsinclair
https://codereview.chromium.org/2089443002/diff/20001/xfa/fxfa/parser/xfa_basic_imp.cpp File xfa/fxfa/parser/xfa_basic_imp.cpp (right): https://codereview.chromium.org/2089443002/diff/20001/xfa/fxfa/parser/xfa_basic_imp.cpp#newcode198 xfa/fxfa/parser/xfa_basic_imp.cpp:198: return (static_cast<int32_t>(eName) < g_iXFAElementCount) On 2016/06/20 21:43:16, Lei Zhang ...
4 years, 6 months ago (2016-06-21 13:43:08 UTC) #4
Lei Zhang
https://codereview.chromium.org/2089443002/diff/40001/xfa/fxfa/parser/xfa_basic_imp.cpp File xfa/fxfa/parser/xfa_basic_imp.cpp (right): https://codereview.chromium.org/2089443002/diff/40001/xfa/fxfa/parser/xfa_basic_imp.cpp#newcode233 xfa/fxfa/parser/xfa_basic_imp.cpp:233: if (static_cast<int32_t>(eElement) >= g_iXFAElementCount) { One more unknown check?
4 years, 6 months ago (2016-06-21 16:37:03 UTC) #5
dsinclair
https://codereview.chromium.org/2089443002/diff/40001/xfa/fxfa/parser/xfa_basic_imp.cpp File xfa/fxfa/parser/xfa_basic_imp.cpp (right): https://codereview.chromium.org/2089443002/diff/40001/xfa/fxfa/parser/xfa_basic_imp.cpp#newcode233 xfa/fxfa/parser/xfa_basic_imp.cpp:233: if (static_cast<int32_t>(eElement) >= g_iXFAElementCount) { On 2016/06/21 16:37:03, Lei ...
4 years, 6 months ago (2016-06-21 20:03:10 UTC) #6
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-21 20:18:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089443002/80001
4 years, 6 months ago (2016-06-21 20:18:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_xfa_clang on master.tryserver.client.pdfium (JOB_FAILED, no build URL)
4 years, 6 months ago (2016-06-21 20:19:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089443002/80001
4 years, 6 months ago (2016-06-21 20:21:28 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_xfa_clang on master.tryserver.client.pdfium (JOB_FAILED, no build URL)
4 years, 6 months ago (2016-06-21 20:22:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089443002/80001
4 years, 6 months ago (2016-06-21 20:45:58 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_xfa_clang on master.tryserver.client.pdfium (JOB_FAILED, no build URL)
4 years, 6 months ago (2016-06-21 20:46:49 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089443002/80001
4 years, 6 months ago (2016-06-21 20:59:53 UTC) #21
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 21:15:32 UTC) #23
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/56a8b1944d555ed65dda97164b702a9a6574...

Powered by Google App Engine
This is Rietveld 408576698