xfa/fxfa/parser/cxfa_stroke.h - Issue 2089443002: Convert XFA_ELEMENT to an enum class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/cxfa_stroke.h

Issue 2089443002: Convert XFA_ELEMENT to an enum class (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: More unknown checks Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/parser/cxfa_stroke.h

diff --git a/xfa/fxfa/parser/cxfa_stroke.h b/xfa/fxfa/parser/cxfa_stroke.h

index 719ac1bbcf2821b2e2cfd6382cc168ca42bb23be..f455edc69efe3e81ac6fd20214428b631a3c68d9 100644

--- a/xfa/fxfa/parser/cxfa_stroke.h

+++ b/xfa/fxfa/parser/cxfa_stroke.h

@@ -23,8 +23,8 @@ class CXFA_Stroke : public CXFA_Data {

public:

explicit CXFA_Stroke(CXFA_Node* pNode) : CXFA_Data(pNode) {}

- bool IsCorner() const { return GetClassID() == XFA_ELEMENT_Corner; }

- bool IsEdge() const { return GetClassID() == XFA_ELEMENT_Edge; }

+ bool IsCorner() const { return GetClassID() == XFA_Element::Corner; }

+ bool IsEdge() const { return GetClassID() == XFA_Element::Edge; }

bool IsVisible() const { return GetPresence() == XFA_ATTRIBUTEENUM_Visible; }

int32_t GetPresence() const;

int32_t GetCapType() const;

« no previous file with comments | « xfa/fxfa/parser/cxfa_line.cpp ('k') | xfa/fxfa/parser/cxfa_stroke.cpp » ('j') | no next file with comments »