xfa/fxfa/parser/xfa_layout_appadapter.h - Issue 2089443002: Convert XFA_ELEMENT to an enum class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/xfa_layout_appadapter.h

Issue 2089443002: Convert XFA_ELEMENT to an enum class (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: More unknown checks Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/parser/xfa_layout_appadapter.h

diff --git a/xfa/fxfa/parser/xfa_layout_appadapter.h b/xfa/fxfa/parser/xfa_layout_appadapter.h

index d41b90a9c7587383ae5bd9eab589bad5c2a3275f..118c273f84bfa3db5463076794cb556dc54abcdd 100644

--- a/xfa/fxfa/parser/xfa_layout_appadapter.h

+++ b/xfa/fxfa/parser/xfa_layout_appadapter.h

@@ -13,7 +13,7 @@ class CXFA_TraverseStrategy_PageAreaContainerLayoutItem {

public:

static inline CXFA_ContainerLayoutItem* GetFirstChild(

CXFA_ContainerLayoutItem* pLayoutItem) {

- if (pLayoutItem->m_pFormNode->GetClassID() == XFA_ELEMENT_PageSet) {

+ if (pLayoutItem->m_pFormNode->GetClassID() == XFA_Element::PageSet) {

return static_cast<CXFA_ContainerLayoutItem*>(pLayoutItem->m_pFirstChild);

}

return NULL;