Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Unified Diff: xfa/fxfa/parser/cxfa_event.cpp

Issue 2089443002: Convert XFA_ELEMENT to an enum class (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: More unknown checks Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fxfa/parser/cxfa_event.h ('k') | xfa/fxfa/parser/cxfa_fill.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fxfa/parser/cxfa_event.cpp
diff --git a/xfa/fxfa/parser/cxfa_event.cpp b/xfa/fxfa/parser/cxfa_event.cpp
index efff3e5161b647125ac8413933639bae5eccccd6..1eb182ec3bde7ab23ce79d37c24ecf38e64d10d1 100644
--- a/xfa/fxfa/parser/cxfa_event.cpp
+++ b/xfa/fxfa/parser/cxfa_event.cpp
@@ -14,16 +14,16 @@ int32_t CXFA_Event::GetActivity() {
return m_pNode->GetEnum(XFA_ATTRIBUTE_Activity);
}
-int32_t CXFA_Event::GetEventType() {
+XFA_Element CXFA_Event::GetEventType() {
CXFA_Node* pChild = m_pNode->GetNodeItem(XFA_NODEITEM_FirstChild);
while (pChild) {
- int32_t eType = pChild->GetClassID();
- if (eType != XFA_ELEMENT_Extras)
+ XFA_Element eType = pChild->GetClassID();
+ if (eType != XFA_Element::Extras)
return eType;
pChild = pChild->GetNodeItem(XFA_NODEITEM_NextSibling);
}
- return XFA_ELEMENT_UNKNOWN;
+ return XFA_Element::Unknown;
}
void CXFA_Event::GetRef(CFX_WideStringC& wsRef) {
@@ -31,15 +31,15 @@ void CXFA_Event::GetRef(CFX_WideStringC& wsRef) {
}
CXFA_Script CXFA_Event::GetScript() {
- return CXFA_Script(m_pNode->GetChild(0, XFA_ELEMENT_Script));
+ return CXFA_Script(m_pNode->GetChild(0, XFA_Element::Script));
}
CXFA_Submit CXFA_Event::GetSubmit() {
- return CXFA_Submit(m_pNode->GetChild(0, XFA_ELEMENT_Submit));
+ return CXFA_Submit(m_pNode->GetChild(0, XFA_Element::Submit));
}
void CXFA_Event::GetSignDataTarget(CFX_WideString& wsTarget) {
- CXFA_Node* pNode = m_pNode->GetProperty(0, XFA_ELEMENT_SignData);
+ CXFA_Node* pNode = m_pNode->GetProperty(0, XFA_Element::SignData);
if (!pNode)
return;
« no previous file with comments | « xfa/fxfa/parser/cxfa_event.h ('k') | xfa/fxfa/parser/cxfa_fill.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698