Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2088003002: Add a command line option to the running of some file manager tests (Closed)

Created:
4 years, 6 months ago by dtapuska
Modified:
4 years, 6 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@android_webview_event
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a command line option to the running of some file manager tests These file manager tests dispatch untrusted events at the DOM. Blink is changing the default for this option. Ultimately these tests need to be reworked so they don't dispatch default actions. BUG=520519 Committed: https://crrev.com/0a3db18907800f929a288c39c396c3143ee145f9 Cr-Commit-Position: refs/heads/master@{#401141}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 5 chunks +20 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
dtapuska
4 years, 6 months ago (2016-06-21 20:53:18 UTC) #2
fukino
lgtm. Thanks!
4 years, 6 months ago (2016-06-21 21:06:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088003002/1
4 years, 6 months ago (2016-06-21 23:47:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 23:54:13 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 23:56:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a3db18907800f929a288c39c396c3143ee145f9
Cr-Commit-Position: refs/heads/master@{#401141}

Powered by Google App Engine
This is Rietveld 408576698