Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Issue 2088003002: Add a command line option to the running of some file manager tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@android_webview_event
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
diff --git a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
index cc3208f6ac2e3a7aa27822538e367fbd22168ef5..4514bc6f8f606abc123aceb4a92cb562fe7976f5 100644
--- a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
+++ b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
@@ -39,11 +39,26 @@ IN_PROC_BROWSER_TEST_P(FileManagerBrowserTest, Test) {
StartTest();
}
+// Test fixture class for tests that rely on deprecated event dispatch that send
+// tests.
+class FileManagerBrowserTestWithLegacyEventDispatch
+ : public FileManagerBrowserTest {
+ void SetUpCommandLine(base::CommandLine* command_line) override {
+ FileManagerBrowserTest::SetUpCommandLine(command_line);
+ command_line->AppendSwitchASCII("disable-blink-features",
+ "TrustedEventsDefaultAction");
+ }
+};
+
+IN_PROC_BROWSER_TEST_P(FileManagerBrowserTestWithLegacyEventDispatch, Test) {
+ StartTest();
+}
+
// Test fixture class for details panel.
// TODO(ryoh): remove after we release details panel feature.
class FileManagerDetailsPanelBrowserTest : public FileManagerBrowserTest {
void SetUpCommandLine(base::CommandLine* command_line) override {
- FileManagerBrowserTestBase::SetUpCommandLine(command_line);
+ FileManagerBrowserTest::SetUpCommandLine(command_line);
command_line->AppendSwitch("--enable-files-details-panel");
}
};
@@ -425,7 +440,7 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(
#endif
WRAPPED_INSTANTIATE_TEST_CASE_P(
MAYBE_TabIndex,
- FileManagerBrowserTest,
+ FileManagerBrowserTestWithLegacyEventDispatch,
::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "searchBoxFocus")));
#if defined(DISABLE_SLOW_FILESAPP_TESTS)
@@ -435,7 +450,7 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(
#endif
WRAPPED_INSTANTIATE_TEST_CASE_P(
MAYBE_TabindexFocus,
- FileManagerBrowserTest,
+ FileManagerBrowserTestWithLegacyEventDispatch,
::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "tabindexFocus")));
#if defined(DISABLE_SLOW_FILESAPP_TESTS)
@@ -445,7 +460,7 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(
#endif
WRAPPED_INSTANTIATE_TEST_CASE_P(
MAYBE_TabindexFocusDownloads,
- FileManagerBrowserTest,
+ FileManagerBrowserTestWithLegacyEventDispatch,
::testing::Values(TestParameter(NOT_IN_GUEST_MODE,
"tabindexFocusDownloads"),
TestParameter(IN_GUEST_MODE, "tabindexFocusDownloads")));
@@ -458,7 +473,7 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(
#endif
WRAPPED_INSTANTIATE_TEST_CASE_P(
MAYBE_TabindexFocusDirectorySelected,
- FileManagerBrowserTest,
+ FileManagerBrowserTestWithLegacyEventDispatch,
::testing::Values(TestParameter(NOT_IN_GUEST_MODE,
"tabindexFocusDirectorySelected")));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698