Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2089763002: Fix android webview unit tests to dispatch correct click event. (Closed)

Created:
4 years, 6 months ago by dtapuska
Modified:
4 years, 6 months ago
Reviewers:
michaelbai
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix android webview unit tests to dispatch correct click event. The click event had the incorrect event type. It should be a mouse event and not a generic event. BUG=520519 Committed: https://crrev.com/afc3aed8662f751c5403fd6a2ba8cbe6e1e41ace Cr-Commit-Position: refs/heads/master@{#401138}

Patch Set 1 #

Patch Set 2 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/util/JSUtils.java View 1 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
dtapuska
4 years, 6 months ago (2016-06-21 20:37:30 UTC) #2
michaelbai
lgtm
4 years, 6 months ago (2016-06-21 22:30:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089763002/20001
4 years, 6 months ago (2016-06-21 23:38:13 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 23:44:53 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 23:46:52 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/afc3aed8662f751c5403fd6a2ba8cbe6e1e41ace
Cr-Commit-Position: refs/heads/master@{#401138}

Powered by Google App Engine
This is Rietveld 408576698