Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 2084003004: Disable chromevox time widget and date widget tests. (Closed)

Created:
4 years, 6 months ago by dtapuska
Modified:
4 years, 6 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@chromeos_file_manager
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable chromevox time widget and date widget tests. These are deprecated test suites and they conflict with the blink feature to disable dispatching the default action on untrusted events. Disable them since this code will eventually be removed when chromevox2 moves from beta to stable and it is not worth spending time fixing them. BUG=520519 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/aa38a3bf68c3704a42a3588cfa6476e1f1754374 Cr-Commit-Position: refs/heads/master@{#401289}

Patch Set 1 #

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher_test.unitjs View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dtapuska
4 years, 6 months ago (2016-06-21 21:00:25 UTC) #3
dmazzoni
lgtm Please add a comment and bug url to the code explaining why they're disabled.
4 years, 6 months ago (2016-06-21 21:03:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084003004/20001
4 years, 6 months ago (2016-06-22 14:57:39 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 15:41:26 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 15:44:00 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aa38a3bf68c3704a42a3588cfa6476e1f1754374
Cr-Commit-Position: refs/heads/master@{#401289}

Powered by Google App Engine
This is Rietveld 408576698