Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: components/constrained_window/test_create_native_web_modal_manager_cocoa.cc

Issue 2087643003: Move web modal dialog manager files into the constrained_window component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert NativeManagerTracker split, delete CreateNativeWebModalManager impls w/ two left for Cocoa a… Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/constrained_window/test_create_native_web_modal_manager_cocoa.cc
diff --git a/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc b/components/constrained_window/test_create_native_web_modal_manager_cocoa.cc
similarity index 58%
rename from chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc
rename to components/constrained_window/test_create_native_web_modal_manager_cocoa.cc
index 94ab725c0da13402fa1c06240990bf47710b3704..7c4fe6e357ed7de9503bee944693aca09d414396 100644
--- a/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc
+++ b/components/constrained_window/test_create_native_web_modal_manager_cocoa.cc
@@ -1,19 +1,20 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "components/web_modal/web_contents_modal_dialog_manager.h"
+#include "components/constrained_window/constrained_window_views.h"
-#include "chrome/browser/ui/views/native_web_contents_modal_dialog_manager_views.h"
#include "components/web_modal/single_web_contents_dialog_manager.h"
tapted 2016/07/19 09:29:41 These 3 includes should be unnecessary
Patti Lor 2016/07/28 01:29:31 Done.
+#include "components/web_modal/web_contents_modal_dialog_manager.h"
+#include "ui/gfx/native_widget_types.h"
namespace web_modal {
SingleWebContentsDialogManager*
WebContentsModalDialogManager::CreateNativeWebModalManager(
gfx::NativeWindow dialog,
- SingleWebContentsDialogManagerDelegate* native_delegate) {
- return new NativeWebContentsModalDialogManagerViews(dialog, native_delegate);
+ web_modal::SingleWebContentsDialogManagerDelegate* delegate) {
+ return nullptr;
}
} // namespace web_modal

Powered by Google App Engine
This is Rietveld 408576698