components/constrained_window/test_create_native_web_modal_manager_cocoa.cc - Issue 2087643003: Move web modal dialog manager files into the constrained_window component.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/constrained_window/test_create_native_web_modal_manager_cocoa.cc

Issue 2087643003: Move web modal dialog manager files into the constrained_window component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert NativeManagerTracker split, delete CreateNativeWebModalManager impls w/ two left for Cocoa a… Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/constrained_window/show_modal_dialog_cocoa.cc ('K') | « components/constrained_window/show_modal_dialog_views.cc ('k') | components/web_modal.gypi » ('j') | components/web_modal/web_contents_modal_dialog_manager.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 #include "components/constrained_window/constrained_window_views.h"

	6

	7 #include "components/web_modal/single_web_contents_dialog_manager.h"
	tapted 2016/07/19 09:29:41 These 3 includes should be unnecessary These 3 includes should be unnecessary Patti Lor 2016/07/28 01:29:31 Done. Show quoted text On 2016/07/19 09:29:41, tapted wrote: > These 3 includes should be unnecessary Done.
5 #include "components/web_modal/web_contents_modal_dialog_manager.h"	8 #include "components/web_modal/web_contents_modal_dialog_manager.h"

6	9 #include "ui/gfx/native_widget_types.h"

7 #include "chrome/browser/ui/views/native_web_contents_modal_dialog_manager_views .h"

8 #include "components/web_modal/single_web_contents_dialog_manager.h"

9	10

10 namespace web_modal {	11 namespace web_modal {

11	12

12 SingleWebContentsDialogManager*	13 SingleWebContentsDialogManager*

13 WebContentsModalDialogManager::CreateNativeWebModalManager(	14 WebContentsModalDialogManager::CreateNativeWebModalManager(

14 gfx::NativeWindow dialog,	15 gfx::NativeWindow dialog,

15 SingleWebContentsDialogManagerDelegate* native_delegate) {	16 web_modal::SingleWebContentsDialogManagerDelegate* delegate) {

16 return new NativeWebContentsModalDialogManagerViews(dialog, native_delegate);	17 return nullptr;

17 }	18 }

18	19

19 } // namespace web_modal	20 } // namespace web_modal

OLD	NEW