Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Unified Diff: components/constrained_window/show_modal_dialog_cocoa.cc

Issue 2087643003: Move web modal dialog manager files into the constrained_window component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert NativeManagerTracker split, delete CreateNativeWebModalManager impls w/ two left for Cocoa a… Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/constrained_window/show_modal_dialog_cocoa.cc
diff --git a/components/constrained_window/show_modal_dialog_cocoa.cc b/components/constrained_window/show_modal_dialog_cocoa.cc
new file mode 100644
index 0000000000000000000000000000000000000000..7fea1b942ea54850c5c25bfd062b9573958d0ca0
--- /dev/null
+++ b/components/constrained_window/show_modal_dialog_cocoa.cc
@@ -0,0 +1,33 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/constrained_window/constrained_window_views.h"
+
+#include <memory>
+
+#include "components/web_modal/single_web_contents_dialog_manager.h"
+#include "components/web_modal/web_contents_modal_dialog_manager.h"
+#include "content/public/browser/web_contents.h"
+#include "ui/gfx/native_widget_types.h"
+
+// TODO(patricialor): This is a layering violation and should be deleted.
+// Currently it's needed because on Cocoa, the dialog needs to be shown with a
+// SingleWebContentsDialogManagerViewsMac, which depends on things inside
+// chrome/browser/ui/cocoa/constrained_window/* and thus can't be moved out into
+// components/constrained_window/*.
tapted 2016/07/19 09:29:41 add something like "For this to work at all, Creat
Patti Lor 2016/07/28 01:29:31 Done.
+
+namespace constrained_window {
+
+void ShowModalDialog(gfx::NativeWindow dialog,
+ content::WebContents* initiator_web_contents) {
+ web_modal::WebContentsModalDialogManager* manager =
+ web_modal::WebContentsModalDialogManager::FromWebContents(
+ initiator_web_contents);
+ std::unique_ptr<web_modal::SingleWebContentsDialogManager> dialog_manager(
+ web_modal::WebContentsModalDialogManager::CreateNativeWebModalManager(
+ dialog, manager));
+ manager->ShowDialogWithManager(dialog, std::move(dialog_manager));
+}
+
+} // namespace constrained_window

Powered by Google App Engine
This is Rietveld 408576698