components/web_modal/web_contents_modal_dialog_manager.h - Issue 2087643003: Move web modal dialog manager files into the constrained_window component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_modal/web_contents_modal_dialog_manager.h

Issue 2087643003: Move web modal dialog manager files into the constrained_window component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert NativeManagerTracker split, delete CreateNativeWebModalManager impls w/ two left for Cocoa a… Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/constrained_window/test_create_native_web_modal_manager_cocoa.cc ('K') | « components/web_modal.gypi ('k') | components/web_modal/web_contents_modal_dialog_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_modal/web_contents_modal_dialog_manager.h

diff --git a/components/web_modal/web_contents_modal_dialog_manager.h b/components/web_modal/web_contents_modal_dialog_manager.h

index 6505301c215f73fa3e250b800f239dd3de988208..29d49a3c95f0a5b6c84d7e25c620ec8c70277cd0 100644

--- a/components/web_modal/web_contents_modal_dialog_manager.h

+++ b/components/web_modal/web_contents_modal_dialog_manager.h

@@ -29,13 +29,11 @@ class WebContentsModalDialogManager

WebContentsModalDialogManagerDelegate* delegate() const { return delegate_; }

void SetDelegate(WebContentsModalDialogManagerDelegate* d);

+#if defined(OS_MACOSX)

static SingleWebContentsDialogManager* CreateNativeWebModalManager(

tapted 2016/07/19 09:29:41 nit: add a note here that this is not defined in t

Patti Lor 2016/07/28 01:29:31 Done.

gfx::NativeWindow dialog,

SingleWebContentsDialogManagerDelegate* native_delegate);

- // Shows the dialog as a web contents modal dialog. The dialog will notify via

- // WillClose() when it is being destroyed.

- void ShowModalDialog(gfx::NativeWindow dialog);

+#endif

// Allow clients to supply their own native dialog manager. Suitable for

// bubble clients.