Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2087153003: Moves common code in ash/wm/overview to ash/common/wm/overview (Closed)

Created:
4 years, 6 months ago by sky
Modified:
4 years, 6 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves common code in ash/wm/overview to ash/common/wm/overview This code now only depends upon ash/common types, so it can be moved. This is a straight file move (with a format). BUG=581868 TEST=covered by tests R=jamescook@chromium.org Committed: https://crrev.com/7c2c40af68d1b6a78f0ce8525a333be37ea038fe Cr-Commit-Position: refs/heads/master@{#401425}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -3890 lines) Patch
M ash/accelerators/accelerator_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/ash.gyp View 2 chunks +14 lines, -14 lines 0 comments Download
M ash/aura/wm_shell_aura.cc View 2 chunks +1 line, -1 line 0 comments Download
A + ash/common/wm/overview/overview_animation_type.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/wm/overview/scoped_overview_animation_settings.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/wm/overview/scoped_overview_animation_settings_factory.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/wm/overview/scoped_overview_animation_settings_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/wm/overview/scoped_transform_overview_window.h View 3 chunks +6 lines, -7 lines 0 comments Download
A + ash/common/wm/overview/scoped_transform_overview_window.cc View 9 chunks +17 lines, -23 lines 0 comments Download
A + ash/common/wm/overview/window_grid.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/wm/overview/window_grid.cc View 7 chunks +15 lines, -15 lines 0 comments Download
A + ash/common/wm/overview/window_selector.h View 3 chunks +4 lines, -9 lines 0 comments Download
A + ash/common/wm/overview/window_selector.cc View 9 chunks +17 lines, -19 lines 0 comments Download
A + ash/common/wm/overview/window_selector_controller.h View 3 chunks +6 lines, -7 lines 0 comments Download
A + ash/common/wm/overview/window_selector_controller.cc View 2 chunks +6 lines, -9 lines 0 comments Download
A + ash/common/wm/overview/window_selector_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/wm/overview/window_selector_item.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/wm/overview/window_selector_item.cc View 4 chunks +11 lines, -13 lines 0 comments Download
M ash/desktop_background/desktop_background_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/overview/overview_button_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/overview/overview_button_tray_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/gestures/overview_gesture_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/gestures/overview_gesture_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
D ash/wm/overview/DEPS View 1 chunk +0 lines, -32 lines 0 comments Download
D ash/wm/overview/overview_animation_type.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ash/wm/overview/scoped_overview_animation_settings.h View 1 chunk +0 lines, -19 lines 0 comments Download
M ash/wm/overview/scoped_overview_animation_settings_aura.h View 1 chunk +2 lines, -2 lines 0 comments Download
D ash/wm/overview/scoped_overview_animation_settings_factory.h View 1 chunk +0 lines, -36 lines 0 comments Download
D ash/wm/overview/scoped_overview_animation_settings_factory.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M ash/wm/overview/scoped_overview_animation_settings_factory_aura.h View 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/overview/scoped_transform_overview_window.h View 1 chunk +0 lines, -156 lines 0 comments Download
D ash/wm/overview/scoped_transform_overview_window.cc View 1 chunk +0 lines, -435 lines 0 comments Download
D ash/wm/overview/window_grid.h View 1 chunk +0 lines, -183 lines 0 comments Download
D ash/wm/overview/window_grid.cc View 1 chunk +0 lines, -954 lines 0 comments Download
D ash/wm/overview/window_selector.h View 1 chunk +0 lines, -189 lines 0 comments Download
D ash/wm/overview/window_selector.cc View 1 chunk +0 lines, -690 lines 0 comments Download
D ash/wm/overview/window_selector_controller.h View 1 chunk +0 lines, -63 lines 0 comments Download
D ash/wm/overview/window_selector_controller.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D ash/wm/overview/window_selector_delegate.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ash/wm/overview/window_selector_item.h View 1 chunk +0 lines, -197 lines 0 comments Download
D ash/wm/overview/window_selector_item.cc View 1 chunk +0 lines, -597 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
sky
4 years, 6 months ago (2016-06-22 19:21:22 UTC) #1
James Cook
LGTM. BTW, I typically don't reformat the entire directory when I do moves -- I ...
4 years, 6 months ago (2016-06-22 19:45:48 UTC) #2
sky
I do the same, run git cl format.
4 years, 6 months ago (2016-06-22 19:46:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087153003/1
4 years, 6 months ago (2016-06-22 19:47:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 22:05:30 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 22:09:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c2c40af68d1b6a78f0ce8525a333be37ea038fe
Cr-Commit-Position: refs/heads/master@{#401425}

Powered by Google App Engine
This is Rietveld 408576698