Moves WindowSelectorController onto WmShell

Moves WindowSelectorController onto WmShell

And removes WmShell::IsOverviewMode* functions as they are no longer
necessary.

BUG=581868
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/3be9c595a504323874a27cbbc37509c03fd97e2c
Cr-Commit-Position: refs/heads/master@{#401494}

[James Cook, 2016-06-22 22:46:19]

LGTM with a couple suggestions

https://codereview.chromium.org/2084503007/diff/20001/ash/common/wm_shell.cc
File ash/common/wm_shell.cc (right):

https://codereview.chromium.org/2084503007/diff/20001/ash/common/wm_shell.cc#...
ash/common/wm_shell.cc:71: window_selector_controller_.reset(new
WindowSelectorController());
WindowSelectorController does nothing in its constructor and destructor. Do you
think it could be initialized in the WmShell constructor, similar to
FocusCycler?

This would eliminate the need for null checks with window_selector_controller().

https://codereview.chromium.org/2084503007/diff/20001/ash/wm/gestures/overvie...
File ash/wm/gestures/overview_gesture_handler.cc (right):

https://codereview.chromium.org/2084503007/diff/20001/ash/wm/gestures/overvie...
ash/wm/gestures/overview_gesture_handler.cc:63:
Shell::GetInstance()->metrics()->RecordUserMetricsAction(
nit: This could become WmShell::Get()->RecordUserMetricsAction() and eliminate
#include shell.h and user_metrics_recorder.h

[sky, 2016-06-22 23:19:39]

https://codereview.chromium.org/2084503007/diff/20001/ash/common/wm_shell.cc
File ash/common/wm_shell.cc (right):

https://codereview.chromium.org/2084503007/diff/20001/ash/common/wm_shell.cc#...
ash/common/wm_shell.cc:71: window_selector_controller_.reset(new
WindowSelectorController());
On 2016/06/22 22:46:19, James Cook wrote:
> WindowSelectorController does nothing in its constructor and destructor. Do
you
> think it could be initialized in the WmShell constructor, similar to
> FocusCycler?

I made construction immediate, but destruction has to be explicit. While it
looks like ~WSC does nothing, it deletes the WindowSelector, which deletes a
bunch of other stuff. The deletion has to happen where it is or we have shutdown
problems.

> This would eliminate the need for null checks with
window_selector_controller().

I suspect these were never really needed.

https://codereview.chromium.org/2084503007/diff/20001/ash/wm/gestures/overvie...
File ash/wm/gestures/overview_gesture_handler.cc (right):

https://codereview.chromium.org/2084503007/diff/20001/ash/wm/gestures/overvie...
ash/wm/gestures/overview_gesture_handler.cc:63:
Shell::GetInstance()->metrics()->RecordUserMetricsAction(
On 2016/06/22 22:46:19, James Cook wrote:
> nit: This could become WmShell::Get()->RecordUserMetricsAction() and eliminate
> #include shell.h and user_metrics_recorder.h

Done.

[sky, 2016-06-22 23:54:40]

The CQ bit was checked by sky@chromium.org

[sky, 2016-06-22 23:54:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2084503007/#ps60001
(title: "fix mash")

[commit-bot: I haz the power, 2016-06-22 23:55:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084503007/60001

[commit-bot: I haz the power, 2016-06-23 01:08:52]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-23 01:11:36]

Description was changed from

==========
Moves WindowSelectorController onto WmShell

And removes WmShell::IsOverviewMode* functions as they are no longer
necessary.

BUG=581868
TEST=covered by tests
R=jamescook@chromium.org
==========

to

==========
Moves WindowSelectorController onto WmShell

And removes WmShell::IsOverviewMode* functions as they are no longer
necessary.

BUG=581868
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/3be9c595a504323874a27cbbc37509c03fd97e2c
Cr-Commit-Position: refs/heads/master@{#401494}
==========

[commit-bot: I haz the power, 2016-06-23 01:11:37]

Patchset 4 (id:??) landed as
https://crrev.com/3be9c595a504323874a27cbbc37509c03fd97e2c
Cr-Commit-Position: refs/heads/master@{#401494}