Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2150)

Unified Diff: content/public/browser/web_contents.h

Issue 2086423005: Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Improving comment and removing the NOTREACHED. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents.h
diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h
index 36996f00cdc50c5c21055e96450d1200cdca1bf1..65de3da3795bda157578c6c706cee694d3d271ef 100644
--- a/content/public/browser/web_contents.h
+++ b/content/public/browser/web_contents.h
@@ -317,6 +317,12 @@ class WebContents : public PageNavigator,
// download, in which case the URL would revert to what it was previously).
virtual const base::string16& GetTitle() const = 0;
+ // Saves the given title to the navigation entry and does associated work. It
+ // will update history and the view with the new title, and also synthesize
+ // titles for file URLs that have none. Thus |entry| must have a URL set.
+ virtual void UpdateTitleForEntry(NavigationEntry* entry,
+ const base::string16& title) = 0;
+
// The max page ID for any page that the current SiteInstance has loaded in
// this WebContents. Page IDs are specific to a given SiteInstance and
// WebContents, corresponding to a specific RenderView in the renderer.

Powered by Google App Engine
This is Rietveld 408576698