Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: content/public/browser/web_contents.h

Issue 2086423005: Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Improving comment and removing the NOTREACHED. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <set> 10 #include <set>
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 310
311 virtual const PageImportanceSignals& GetPageImportanceSignals() const = 0; 311 virtual const PageImportanceSignals& GetPageImportanceSignals() const = 0;
312 312
313 // Tab navigation state ------------------------------------------------------ 313 // Tab navigation state ------------------------------------------------------
314 314
315 // Returns the current navigation properties, which if a navigation is 315 // Returns the current navigation properties, which if a navigation is
316 // pending may be provisional (e.g., the navigation could result in a 316 // pending may be provisional (e.g., the navigation could result in a
317 // download, in which case the URL would revert to what it was previously). 317 // download, in which case the URL would revert to what it was previously).
318 virtual const base::string16& GetTitle() const = 0; 318 virtual const base::string16& GetTitle() const = 0;
319 319
320 // Saves the given title to the navigation entry and does associated work. It
321 // will update history and the view with the new title, and also synthesize
322 // titles for file URLs that have none. Thus |entry| must have a URL set.
323 virtual void UpdateTitleForEntry(NavigationEntry* entry,
324 const base::string16& title) = 0;
325
320 // The max page ID for any page that the current SiteInstance has loaded in 326 // The max page ID for any page that the current SiteInstance has loaded in
321 // this WebContents. Page IDs are specific to a given SiteInstance and 327 // this WebContents. Page IDs are specific to a given SiteInstance and
322 // WebContents, corresponding to a specific RenderView in the renderer. 328 // WebContents, corresponding to a specific RenderView in the renderer.
323 // Page IDs increase with each new page that is loaded by a tab. 329 // Page IDs increase with each new page that is loaded by a tab.
324 virtual int32_t GetMaxPageID() = 0; 330 virtual int32_t GetMaxPageID() = 0;
325 331
326 // The max page ID for any page that the given SiteInstance has loaded in 332 // The max page ID for any page that the given SiteInstance has loaded in
327 // this WebContents. 333 // this WebContents.
328 virtual int32_t GetMaxPageIDForSiteInstance(SiteInstance* site_instance) = 0; 334 virtual int32_t GetMaxPageIDForSiteInstance(SiteInstance* site_instance) = 0;
329 335
(...skipping 419 matching lines...) Expand 10 before | Expand all | Expand 10 after
749 755
750 private: 756 private:
751 // This interface should only be implemented inside content. 757 // This interface should only be implemented inside content.
752 friend class WebContentsImpl; 758 friend class WebContentsImpl;
753 WebContents() {} 759 WebContents() {}
754 }; 760 };
755 761
756 } // namespace content 762 } // namespace content
757 763
758 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 764 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698