Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle()

chrome/browser/task_management/providers/web_contents/web_contents_task_provider.cc

Index: chrome/browser/task_management/providers/web_contents/web_contents_task_provider.cc
diff --git a/chrome/browser/task_management/providers/web_contents/web_contents_task_provider.cc b/chrome/browser/task_management/providers/web_contents/web_contents_task_provider.cc
index f6862a33f3dd7e1330d7d9d3df792f75de86e2c4..452ce24252e3bf0441531f8d4fd4c4948fdb3e18 100644
--- a/chrome/browser/task_management/providers/web_contents/web_contents_task_provider.cc
+++ b/chrome/browser/task_management/providers/web_contents/web_contents_task_provider.cc
@@ -177,11 +177,8 @@ void WebContentsEntry::DidNavigateMainFrame(
     const content::LoadCommittedDetails& details,
     const content::FrameNavigateParams& params) {
   auto itr = tasks_by_frames_.find(web_contents()->GetMainFrame());
-  if (itr == tasks_by_frames_.end()) {
-    // TODO(afakhry): Validate whether this actually happens in practice.
-    NOTREACHED();

[afakhry, 2016/07/14 00:01:53]

Note the removal of these NOTREACHED()s had to be brought back from the CL that
I split from this one: https://codereview.chromium.org/2148083002

We found that it's normal that a WebContents may have a title even though it's
crashed and we're not tracking it.

+  if (itr == tasks_by_frames_.end())
     return;
-  }
 
   // Listening to WebContentsObserver::TitleWasSet() only is not enough in
   // some cases when the the webpage doesn't have a title. That's why we update
@@ -199,11 +196,8 @@ void WebContentsEntry::DidNavigateMainFrame(
 void WebContentsEntry::TitleWasSet(content::NavigationEntry* entry,
                                    bool explicit_set) {
   auto itr = tasks_by_frames_.find(web_contents()->GetMainFrame());
-  if (itr == tasks_by_frames_.end()) {
-    // TODO(afakhry): Validate whether this actually happens in practice.
-    NOTREACHED();
+  if (itr == tasks_by_frames_.end())
     return;
-  }
 
   itr->second->UpdateTitle();
 }