extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc - Issue 2086423005: Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

Issue 2086423005: Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Improving comment and removing the NOTREACHED. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

diff --git a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

index 13f7dc39ac68a7086a992370ec7dfc80beecd830..a58e021b4ba8fe95482c2d568067581fc057d036 100644

--- a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

+++ b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

@@ -182,7 +182,8 @@ void MimeHandlerViewGuest::NavigationStateChanged(

content::NavigationEntry* last_committed_entry =

embedder_web_contents()->GetController().GetLastCommittedEntry();

if (last_committed_entry) {

- last_committed_entry->SetTitle(source->GetTitle());

+ embedder_web_contents()->UpdateTitleForEntry(last_committed_entry,

+ source->GetTitle());

embedder_web_contents()->GetDelegate()->NavigationStateChanged(

embedder_web_contents(), changed_flags);

}

« chrome/browser/task_management/providers/web_contents/web_contents_task_provider.cc ('K') | « content/public/browser/web_contents.h ('k') | no next file » | no next file with comments »