Support GL_SAMPLES queries in null contexts

Support GL_SAMPLES queries in null contexts

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002

Committed: https://skia.googlesource.com/skia/+/64b92a59294a2f73448b3fa8f36f39079f032521
Committed: https://skia.googlesource.com/skia/+/57e98530c113066c4c2d9c64505c52dc25e66c00
Committed: https://skia.googlesource.com/skia/+/b593a76749c6c7e12bf86aeaa06e1e52708e9bdf

[csmartdalton, 2016-06-21 19:19:49]

Description was changed from

==========
Implement queries for GL_SAMPLES in null contexts

BUG=skia:
==========

to

==========
Implement queries for GL_SAMPLES in null contexts

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002
==========

[csmartdalton, 2016-06-21 19:21:16]

Description was changed from

==========
Implement queries for GL_SAMPLES in null contexts

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002
==========

to

==========
Implement queries for GL_SAMPLES in null contexts

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002
==========

[csmartdalton, 2016-06-21 19:21:29]

Description was changed from

==========
Implement queries for GL_SAMPLES in null contexts

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002
==========

to

==========
Support GL_SAMPLES queries in null contexts

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002
==========

[csmartdalton, 2016-06-21 19:25:02]

csmartdalton@google.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2016-06-21 19:55:04]

lgtm

[csmartdalton, 2016-06-21 21:01:32]

The CQ bit was checked by csmartdalton@google.com

[commit-bot: I haz the power, 2016-06-21 21:01:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2085043002/20001

[commit-bot: I haz the power, 2016-06-21 21:27:19]

Description was changed from

==========
Support GL_SAMPLES queries in null contexts

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002
==========

to

==========
Support GL_SAMPLES queries in null contexts

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002

Committed:
https://skia.googlesource.com/skia/+/64b92a59294a2f73448b3fa8f36f39079f032521
==========

[commit-bot: I haz the power, 2016-06-21 21:27:20]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/64b92a59294a2f73448b3fa8f36f39079f032521

[Brian Osman, 2016-06-22 12:57:00]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2089013003/ by brianosman@google.com.

The reason for reverting is: Chrome unit tests failing (eg
https://codereview.chromium.org/2085243002).

[csmartdalton, 2016-06-22 17:33:04]

It's super ugly, but this approach happens to work around the bugs caused by
chrome calling into different testing interfaces during the same test.

[csmartdalton, 2016-06-22 17:47:59]

Description was changed from

==========
Support GL_SAMPLES queries in null contexts

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002

Committed:
https://skia.googlesource.com/skia/+/64b92a59294a2f73448b3fa8f36f39079f032521
==========

to

==========
Support GL_SAMPLES queries in null contexts

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002

Committed:
https://skia.googlesource.com/skia/+/64b92a59294a2f73448b3fa8f36f39079f032521
==========

[bsalomon, 2016-06-22 19:46:02]

<cringe>
lgtm
</cringe>

https://codereview.chromium.org/2085043002/diff/40001/src/gpu/gl/GrGLCreateNu...
File src/gpu/gl/GrGLCreateNullInterface.cpp (right):

https://codereview.chromium.org/2085043002/diff/40001/src/gpu/gl/GrGLCreateNu...
src/gpu/gl/GrGLCreateNullInterface.cpp:147: static Texture* GetSingleInstance()
{
Can you add a comment about why we did this?

[csmartdalton, 2016-06-22 20:04:25]

The CQ bit was checked by csmartdalton@google.com

[csmartdalton, 2016-06-22 20:04:25]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2085043002/#ps60001
(title: "Implement queries for GL_SAMPLES in null contexts")

[commit-bot: I haz the power, 2016-06-22 20:04:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2085043002/60001

[commit-bot: I haz the power, 2016-06-22 20:47:13]

Description was changed from

==========
Support GL_SAMPLES queries in null contexts

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002

Committed:
https://skia.googlesource.com/skia/+/64b92a59294a2f73448b3fa8f36f39079f032521
==========

to

==========
Support GL_SAMPLES queries in null contexts

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002

Committed:
https://skia.googlesource.com/skia/+/64b92a59294a2f73448b3fa8f36f39079f032521
Committed:
https://skia.googlesource.com/skia/+/57e98530c113066c4c2d9c64505c52dc25e66c00
==========

[commit-bot: I haz the power, 2016-06-22 20:47:14]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/57e98530c113066c4c2d9c64505c52dc25e66c00

[Brian Osman, 2016-06-23 13:11:36]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2091773002/ by brianosman@google.com.

The reason for reverting is: ASAN failures (including DEPS roll)..

[csmartdalton, 2016-06-23 15:10:41]

Description was changed from

==========
Support GL_SAMPLES queries in null contexts

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002

Committed:
https://skia.googlesource.com/skia/+/64b92a59294a2f73448b3fa8f36f39079f032521
Committed:
https://skia.googlesource.com/skia/+/57e98530c113066c4c2d9c64505c52dc25e66c00
==========

to

==========
Support GL_SAMPLES queries in null contexts

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002

Committed:
https://skia.googlesource.com/skia/+/64b92a59294a2f73448b3fa8f36f39079f032521
Committed:
https://skia.googlesource.com/skia/+/57e98530c113066c4c2d9c64505c52dc25e66c00
==========

[csmartdalton, 2016-06-23 15:11:27]

csmartdalton@google.com changed reviewers:
+ brianosman@google.com

[csmartdalton, 2016-06-23 15:11:28]

Ugh. GLObject didn't have a virtual destructor so the Framebuffer's ref'd
attachments were getting leaked.

[bsalomon, 2016-06-23 15:17:07]

On 2016/06/23 15:11:28, csmartdalton wrote:
> Ugh. GLObject didn't have a virtual destructor so the Framebuffer's ref'd
> attachments were getting leaked.

lgtm

[csmartdalton, 2016-06-23 20:08:49]

The CQ bit was checked by csmartdalton@google.com

[csmartdalton, 2016-06-23 20:08:49]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2085043002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-23 20:08:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2085043002/100001

[commit-bot: I haz the power, 2016-06-23 20:42:18]

Description was changed from

==========
Support GL_SAMPLES queries in null contexts

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002

Committed:
https://skia.googlesource.com/skia/+/64b92a59294a2f73448b3fa8f36f39079f032521
Committed:
https://skia.googlesource.com/skia/+/57e98530c113066c4c2d9c64505c52dc25e66c00
==========

to

==========
Support GL_SAMPLES queries in null contexts

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002

Committed:
https://skia.googlesource.com/skia/+/64b92a59294a2f73448b3fa8f36f39079f032521
Committed:
https://skia.googlesource.com/skia/+/57e98530c113066c4c2d9c64505c52dc25e66c00
Committed:
https://skia.googlesource.com/skia/+/b593a76749c6c7e12bf86aeaa06e1e52708e9bdf
==========

[commit-bot: I haz the power, 2016-06-23 20:42:19]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/b593a76749c6c7e12bf86aeaa06e1e52708e9bdf