Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: src/code-stubs.cc

Issue 2084913006: [ic] Let LoadGlobalIC load the variable name from TypeFeedbackMetadata. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@fix-load-ic-slow-stub
Patch Set: Addressing comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stub-assembler.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.cc
diff --git a/src/code-stubs.cc b/src/code-stubs.cc
index a4d91a9fa23b2de35911a4e3fa85754b5cdc957b..705701d3d840a7025ac10727dbd8c1e79eedd0f8 100644
--- a/src/code-stubs.cc
+++ b/src/code-stubs.cc
@@ -448,24 +448,24 @@ void LoadGlobalICTrampolineStub::GenerateAssembly(
CodeStubAssembler* assembler) const {
typedef compiler::Node Node;
- Node* name = assembler->Parameter(0);
- Node* slot = assembler->Parameter(1);
- Node* context = assembler->Parameter(2);
+ Node* slot = assembler->Parameter(0);
+ Node* context = assembler->Parameter(1);
Node* vector = assembler->LoadTypeFeedbackVectorForStub();
- CodeStubAssembler::LoadICParameters p(context, nullptr, name, slot, vector);
+ CodeStubAssembler::LoadICParameters p(context, nullptr, nullptr, slot,
+ vector);
assembler->LoadGlobalIC(&p);
}
void LoadGlobalICStub::GenerateAssembly(CodeStubAssembler* assembler) const {
typedef compiler::Node Node;
- Node* name = assembler->Parameter(0);
- Node* slot = assembler->Parameter(1);
- Node* vector = assembler->Parameter(2);
- Node* context = assembler->Parameter(3);
+ Node* slot = assembler->Parameter(0);
+ Node* vector = assembler->Parameter(1);
+ Node* context = assembler->Parameter(2);
- CodeStubAssembler::LoadICParameters p(context, nullptr, name, slot, vector);
+ CodeStubAssembler::LoadICParameters p(context, nullptr, nullptr, slot,
+ vector);
assembler->LoadGlobalIC(&p);
}
« no previous file with comments | « src/code-stub-assembler.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698