Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2081143002: [ic] Don't compile load interceptor handlers for LoadGlobalIC. (Closed)

Created:
4 years, 6 months ago by Igor Sheludko
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Don't compile load interceptor handlers for LoadGlobalIC. As a result LoadGlobalIC requires different slow stubs for each TypeofMode. This CL is a prerequisite for not passing variable name to LoadGlobalIC: the interceptor handler is the only kind of handler that requires a name and therefore LoadGlobalIC dispatcher does not need a variable name as well. BUG=chromium:576312 Committed: https://crrev.com/4f674da2e990d8a05353b89d9699baede752e34a Cr-Commit-Position: refs/heads/master@{#37222}

Patch Set 1 : cleanup #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -34 lines) Patch
M src/builtins.h View 1 chunk +7 lines, -4 lines 0 comments Download
M src/builtins.cc View 2 chunks +13 lines, -2 lines 0 comments Download
M src/ic/ic.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/ic/ic.cc View 2 chunks +19 lines, -14 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 4 chunks +31 lines, -11 lines 0 comments Download
M test/cctest/test-api-interceptors.cc View 1 chunk +46 lines, -0 lines 1 comment Download

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
Igor Sheludko
Michael, PTAL. Toon, FIY.
4 years, 6 months ago (2016-06-23 16:00:37 UTC) #5
mvstanton
LGTM. https://codereview.chromium.org/2081143002/diff/40001/test/cctest/test-api-interceptors.cc File test/cctest/test-api-interceptors.cc (right): https://codereview.chromium.org/2081143002/diff/40001/test/cctest/test-api-interceptors.cc#newcode902 test/cctest/test-api-interceptors.cc:902: } Nice unit test +1.
4 years, 6 months ago (2016-06-23 16:09:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081143002/40001
4 years, 6 months ago (2016-06-23 16:11:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081143002/40001
4 years, 6 months ago (2016-06-23 16:44:50 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 6 months ago (2016-06-23 16:47:46 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 16:51:26 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f674da2e990d8a05353b89d9699baede752e34a
Cr-Commit-Position: refs/heads/master@{#37222}

Powered by Google App Engine
This is Rietveld 408576698