Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: src/builtins.cc

Issue 2084913006: [ic] Let LoadGlobalIC load the variable name from TypeFeedbackMetadata. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@fix-load-ic-slow-stub
Patch Set: Addressing comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/ast.cc ('k') | src/code-stub-assembler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins.cc
diff --git a/src/builtins.cc b/src/builtins.cc
index 984b7093fce182fa7e7699879232d3df0676a762..a61d91f53246969b03951071edb9200d7cd3b81e 100644
--- a/src/builtins.cc
+++ b/src/builtins.cc
@@ -5466,12 +5466,11 @@ void Generate_LoadIC_Miss(CodeStubAssembler* assembler) {
void Generate_LoadGlobalIC_Miss(CodeStubAssembler* assembler) {
typedef compiler::Node Node;
- Node* name = assembler->Parameter(0);
- Node* slot = assembler->Parameter(1);
- Node* vector = assembler->Parameter(2);
- Node* context = assembler->Parameter(3);
+ Node* slot = assembler->Parameter(0);
+ Node* vector = assembler->Parameter(1);
+ Node* context = assembler->Parameter(2);
- assembler->TailCallRuntime(Runtime::kLoadGlobalIC_Miss, context, name, slot,
+ assembler->TailCallRuntime(Runtime::kLoadGlobalIC_Miss, context, slot,
vector);
}
@@ -5498,23 +5497,23 @@ void Generate_LoadIC_Slow(CodeStubAssembler* assembler) {
void Generate_LoadGlobalIC_SlowInsideTypeof(CodeStubAssembler* assembler) {
typedef compiler::Node Node;
- Node* name = assembler->Parameter(0);
- // Node* slot = assembler->Parameter(1);
- // Node* vector = assembler->Parameter(2);
- Node* context = assembler->Parameter(3);
+ Node* slot = assembler->Parameter(0);
+ Node* vector = assembler->Parameter(1);
+ Node* context = assembler->Parameter(2);
- assembler->TailCallRuntime(Runtime::kGetGlobalInsideTypeof, context, name);
+ assembler->TailCallRuntime(Runtime::kGetGlobalInsideTypeof, context, slot,
+ vector);
}
void Generate_LoadGlobalIC_SlowNotInsideTypeof(CodeStubAssembler* assembler) {
typedef compiler::Node Node;
- Node* name = assembler->Parameter(0);
- // Node* slot = assembler->Parameter(1);
- // Node* vector = assembler->Parameter(2);
- Node* context = assembler->Parameter(3);
+ Node* slot = assembler->Parameter(0);
+ Node* vector = assembler->Parameter(1);
+ Node* context = assembler->Parameter(2);
- assembler->TailCallRuntime(Runtime::kGetGlobalNotInsideTypeof, context, name);
+ assembler->TailCallRuntime(Runtime::kGetGlobalNotInsideTypeof, context, slot,
+ vector);
}
void Generate_KeyedLoadIC_Slow(MacroAssembler* masm) {
« no previous file with comments | « src/ast/ast.cc ('k') | src/code-stub-assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698