Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2083573002: [builtins] Unify Cosh, Sinh and Tanh as exports from flibm (Closed)

Created:
4 years, 6 months ago by mvstanton
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Unify Cosh, Sinh and Tanh as exports from flibm BUG=v8:5086 Committed: https://crrev.com/cede9ce5e1fd4f5abad87709c559c8c7066bc6ee Cr-Commit-Position: refs/heads/master@{#37424}

Patch Set 1 #

Patch Set 2 : Tests. #

Patch Set 3 : Ports #

Patch Set 4 : REBASE and windows fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+686 lines, -190 lines) Patch
M BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/assembler.h View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M src/assembler.cc View 1 2 3 2 chunks +15 lines, -0 lines 0 comments Download
M src/base/ieee754.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/base/ieee754.cc View 1 2 3 1 chunk +176 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 2 3 3 chunks +3 lines, -7 lines 0 comments Download
M src/builtins.h View 1 2 3 4 chunks +10 lines, -1 line 0 comments Download
M src/builtins.cc View 1 2 3 3 chunks +36 lines, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler/instruction-scheduler.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 3 4 chunks +18 lines, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 1 5 chunks +45 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 2 chunks +15 lines, -0 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 2 3 4 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/representation-change.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 2 3 4 chunks +12 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 2 3 4 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M src/external-reference-table.cc View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 1 chunk +2 lines, -169 lines 0 comments Download
M src/v8.gyp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 3 chunks +24 lines, -0 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 2 3 4 chunks +10 lines, -10 lines 0 comments Download
M test/unittests/base/ieee754-unittest.cc View 1 3 chunks +34 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 3 chunks +117 lines, -0 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 3 chunks +42 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
mvstanton
Hi Benedikt, here are some more. I'd propose deleting the fdlibm.js file/directory in a followup.
4 years, 5 months ago (2016-06-28 11:38:55 UTC) #3
Benedikt Meurer
LGTM modulo compile errors.
4 years, 5 months ago (2016-06-28 12:20:34 UTC) #5
Benedikt Meurer
So, can we land this to finalize the fixit? :-)
4 years, 5 months ago (2016-06-30 03:30:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2083573002/60001
4 years, 5 months ago (2016-06-30 08:26:51 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-30 08:41:16 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 08:41:30 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 08:44:59 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cede9ce5e1fd4f5abad87709c559c8c7066bc6ee
Cr-Commit-Position: refs/heads/master@{#37424}

Powered by Google App Engine
This is Rietveld 408576698