Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: src/bootstrapper.cc

Issue 2083573002: [builtins] Unify Cosh, Sinh and Tanh as exports from flibm (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE and windows fix. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/base/ieee754.cc ('k') | src/builtins.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index 4e0647bf2a5a09408a14009d6a653b5a354364bc..ba940736dfff6e098afef099fb82b6aedbe4b75b 100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -1679,6 +1679,7 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
SimpleInstallFunction(math, "expm1", Builtins::kMathExpm1, 1, true);
SimpleInstallFunction(math, "clz32", Builtins::kMathClz32, 1, true);
SimpleInstallFunction(math, "cos", Builtins::kMathCos, 1, true);
+ SimpleInstallFunction(math, "cosh", Builtins::kMathCosh, 1, true);
Handle<JSFunction> math_exp =
SimpleInstallFunction(math, "exp", Builtins::kMathExp, 1, true);
native_context()->set_math_exp(*math_exp);
@@ -1700,10 +1701,12 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
native_context()->set_math_pow(*math_pow);
SimpleInstallFunction(math, "round", Builtins::kMathRound, 1, true);
SimpleInstallFunction(math, "sin", Builtins::kMathSin, 1, true);
+ SimpleInstallFunction(math, "sinh", Builtins::kMathSinh, 1, true);
Handle<JSFunction> math_sqrt =
SimpleInstallFunction(math, "sqrt", Builtins::kMathSqrt, 1, true);
native_context()->set_math_sqrt(*math_sqrt);
SimpleInstallFunction(math, "tan", Builtins::kMathTan, 1, true);
+ SimpleInstallFunction(math, "tanh", Builtins::kMathTanh, 1, true);
SimpleInstallFunction(math, "trunc", Builtins::kMathTrunc, 1, true);
// Install math constants.
@@ -2613,13 +2616,6 @@ void Bootstrapper::ExportFromRuntime(Isolate* isolate,
}
{
- // TODO(mvstanton): Remove this when MathSinh, MathCosh and MathTanh are
- // no longer implemented in fdlibm.js.
- SimpleInstallFunction(container, "MathExpm1", Builtins::kMathExpm1, 1,
- true);
- }
-
- {
PrototypeIterator iter(native_context->sloppy_async_function_map());
Handle<JSObject> async_function_prototype(iter.GetCurrent<JSObject>());
« no previous file with comments | « src/base/ieee754.cc ('k') | src/builtins.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698