Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2083433002: Mojo: Remove url type converters. (Closed)

Created:
4 years, 6 months ago by Sam McNally
Modified:
4 years, 6 months ago
Reviewers:
jam, dcheng
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, arv+watch_chromium.org, kinuko+watch, ben+mojo_chromium.org, jsbell+serviceworker_chromium.org, cbentzel+watch_chromium.org, tzik, jam, abarth-chromium, darin-cc_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, nhiroki, feature-media-reviews_chromium.org, alokp+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, michaeln, serviceworker-reviews, Aaron Boodman, kinuko+serviceworker, mkwst+moarreviews-renderer_chromium.org, horo+watch_chromium.org, darin (slow to review), chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo: Remove url type converters. BUG=621383 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977 Cr-Commit-Position: refs/heads/master@{#400900}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -185 lines) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/engagement/site_engagement.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/engagement/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A + chrome/browser/ui/webui/engagement/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/ui/webui/engagement/site_engagement.mojom View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/engagement/site_engagement_ui.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_web_ui_mojo_bindings.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M components/password_manager.gypi View 4 chunks +1 line, -3 lines 0 comments Download
M components/password_manager/content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/content/browser/credential_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/content/browser/credential_manager_impl.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M components/password_manager/content/browser/credential_manager_impl_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M components/password_manager/content/public/cpp/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/content/public/cpp/type_converters.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M components/password_manager/content/public/interfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/content/public/interfaces/credential_manager.mojom View 3 chunks +5 lines, -2 lines 0 comments Download
M components/password_manager/content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/content/renderer/credential_manager_client.cc View 2 chunks +1 line, -3 lines 0 comments Download
M components/password_manager/content/renderer/credential_manager_client_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/frame_mojo_shell.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/common/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A + content/common/image_downloader/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M content/common/image_downloader/image_downloader.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M content/content_browser.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/image_downloader/image_downloader_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/image_downloader/image_downloader_impl.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M device/device_tests.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M device/usb/mojo/type_converters.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/ios_web.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M media/mojo/clients/mojo_cdm.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/clients/mojo_cdm.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M media/mojo/interfaces/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M media/mojo/interfaces/content_decryption_module.mojom View 2 chunks +2 lines, -1 line 0 comments Download
M media/mojo/services/mojo_cdm_service.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M mojo/common/BUILD.gn View 1 2 chunks +0 lines, -18 lines 0 comments Download
A + mojo/common/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M mojo/common/common_type_converters_unittest.cc View 2 chunks +0 lines, -17 lines 0 comments Download
D mojo/common/url_type_converters.h View 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/common/url_type_converters.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M mojo/mojo_base.gyp View 1 2 chunks +0 lines, -15 lines 0 comments Download
M net/interfaces/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
A + net/interfaces/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M net/interfaces/proxy_resolver_service.mojom View 2 chunks +2 lines, -1 line 0 comments Download
M net/net.gyp View 3 chunks +8 lines, -2 lines 0 comments Download
M net/proxy/mojo_proxy_resolver_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/mojo_proxy_resolver_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/proxy/mojo_proxy_resolver_impl_unittest.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M net/proxy/proxy_resolver_factory_mojo.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/proxy/proxy_resolver_factory_mojo_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
Sam McNally
4 years, 6 months ago (2016-06-20 03:02:56 UTC) #6
jam
lgtm
4 years, 6 months ago (2016-06-20 16:18:20 UTC) #7
Sam McNally
+dcheng for mojoms
4 years, 6 months ago (2016-06-20 23:29:32 UTC) #9
dcheng
LGTM,thanks
4 years, 6 months ago (2016-06-21 01:51:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083433002/20001
4 years, 6 months ago (2016-06-21 03:50:08 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 05:40:00 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 05:41:21 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977
Cr-Commit-Position: refs/heads/master@{#400900}

Powered by Google App Engine
This is Rietveld 408576698