Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: mojo/common/common_type_converters_unittest.cc

Issue 2083433002: Mojo: Remove url type converters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/common/OWNERS ('k') | mojo/common/url_type_converters.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/common/common_type_converters_unittest.cc
diff --git a/mojo/common/common_type_converters_unittest.cc b/mojo/common/common_type_converters_unittest.cc
index 302bcbe54ab6d4fcbfcdbf17dad3ffa369700ecb..1740d06a71fcfac4fd547c43d24c08e4bfc8eadb 100644
--- a/mojo/common/common_type_converters_unittest.cc
+++ b/mojo/common/common_type_converters_unittest.cc
@@ -7,7 +7,6 @@
#include <stdint.h>
#include "base/strings/utf_string_conversions.h"
-#include "mojo/common/url_type_converters.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
@@ -71,22 +70,6 @@ TEST(CommonTypeConvertersTest, String16) {
ExpectEqualsMojoString(base::string16(), String::From(base::string16()));
}
-TEST(CommonTypeConvertersTest, URL) {
- GURL url("mojo:foo");
- String mojo_string(String::From(url));
-
- ASSERT_EQ(url.spec(), mojo_string);
- EXPECT_EQ(url.spec(), mojo_string.To<GURL>().spec());
- EXPECT_EQ(url.spec(), String::From(url));
-
- GURL invalid = String().To<GURL>();
- ASSERT_TRUE(invalid.spec().empty());
-
- String string_from_invalid = String::From(invalid);
- EXPECT_FALSE(string_from_invalid.is_null());
- ASSERT_EQ(0U, string_from_invalid.size());
-}
-
TEST(CommonTypeConvertersTest, ArrayUint8ToStdString) {
Array<uint8_t> data(4);
data[0] = 'd';
« no previous file with comments | « mojo/common/OWNERS ('k') | mojo/common/url_type_converters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698