components/password_manager/content/renderer/credential_manager_client.cc - Issue 2083433002: Mojo: Remove url type converters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/renderer/credential_manager_client.cc

Issue 2083433002: Mojo: Remove url type converters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/renderer/BUILD.gn ('k') | components/password_manager/content/renderer/credential_manager_client_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/renderer/credential_manager_client.cc

diff --git a/components/password_manager/content/renderer/credential_manager_client.cc b/components/password_manager/content/renderer/credential_manager_client.cc

index 91efb3047634f4d67c472f849bc5ec08128daa13..0f8d9689564f16feb5207b78116331d2ee08fa0f 100644

--- a/components/password_manager/content/renderer/credential_manager_client.cc

+++ b/components/password_manager/content/renderer/credential_manager_client.cc

@@ -16,7 +16,6 @@

#include "content/public/common/service_registry.h"

#include "content/public/renderer/render_frame.h"

#include "content/public/renderer/render_view.h"

-#include "mojo/common/url_type_converters.h"

#include "third_party/WebKit/public/platform/WebCredential.h"

#include "third_party/WebKit/public/platform/WebCredentialManagerError.h"

#include "third_party/WebKit/public/platform/WebFederatedCredential.h"

@@ -201,8 +200,7 @@ void CredentialManagerClient::dispatchGet(

federation_vector.push_back(federations[i]);

mojo_cm_service_->Get(

- zero_click_only, include_passwords,

- mojo::Array<mojo::String>::From(federation_vector),

+ zero_click_only, include_passwords, std::move(federation_vector),

base::Bind(&RespondToRequestCallback,

base::Owned(new RequestCallbacksWrapper(callbacks))));

}