Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: components/password_manager/content/public/interfaces/credential_manager.mojom

Issue 2083433002: Mojo: Remove url type converters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/public/interfaces/credential_manager.mojom
diff --git a/components/password_manager/content/public/interfaces/credential_manager.mojom b/components/password_manager/content/public/interfaces/credential_manager.mojom
index cc9492bb68aaf65b10ed77f8426d2cebddd7f7f7..6b4fe3ee01d5cc9575e4f0ccb7c4de227c4e5b97 100644
--- a/components/password_manager/content/public/interfaces/credential_manager.mojom
+++ b/components/password_manager/content/public/interfaces/credential_manager.mojom
@@ -5,6 +5,7 @@
module password_manager.mojom;
import "url/mojo/origin.mojom";
+import "url/mojo/url.mojom";
enum CredentialType {
EMPTY,
@@ -24,7 +25,7 @@ struct CredentialInfo {
CredentialType type = EMPTY;
string id = "";
string name = "";
- string icon = "";
+ url.mojom.Url icon;
string password = "";
url.mojom.Origin federation;
};
@@ -39,6 +40,8 @@ interface CredentialManager {
// Get Credential. For navigator.credentials.get().
// The result callback will return a non-null and valid CredentialInfo
// if succeeded, or null with a CredentialManagerError if failed.
- Get(bool zero_click_only, bool include_passwords, array<string> federations)
+ Get(bool zero_click_only,
+ bool include_passwords,
+ array<url.mojom.Url> federations)
=> (CredentialManagerError error, CredentialInfo? credential);
};
« no previous file with comments | « components/password_manager/content/public/interfaces/BUILD.gn ('k') | components/password_manager/content/renderer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698