Update GetClassID to GetElementType

Update GetClassID to GetElementType

The GetClassID method actually returns the XFA_Element, change the name of the
method to be more suggestive of the return value.

The GetClassID was sort-of polymorphich and would call down to subclasses. This
CL changes the data to be stored on the CXFA_Object class and just returns what
is set. The values are set in the constructor as needed.

Committed: https://pdfium.googlesource.com/pdfium/+/070fcdfeafb17a9d3ada1418f48fd7f19aa4cf83

[dsinclair, 2016-06-22 18:03:56]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-06-22 18:03:56]

PTAL.

[Lei Zhang, 2016-06-23 05:04:20]

lgtm with nits and commentary on the existing code.

https://codereview.chromium.org/2082573007/diff/1/xfa/fxfa/parser/xfa_documen...
File xfa/fxfa/parser/xfa_document_datamerger_imp.cpp (right):

https://codereview.chromium.org/2082573007/diff/1/xfa/fxfa/parser/xfa_documen...
xfa/fxfa/parser/xfa_document_datamerger_imp.cpp:1094: XFA_Element eClassID =
pFormNode->GetElementType();
BTW, there's still some variables referencing class id.

https://codereview.chromium.org/2082573007/diff/1/xfa/fxfa/parser/xfa_layout_...
File xfa/fxfa/parser/xfa_layout_itemlayout.cpp (right):

https://codereview.chromium.org/2082573007/diff/1/xfa/fxfa/parser/xfa_layout_...
xfa/fxfa/parser/xfa_layout_itemlayout.cpp:2472: m_pFormNode->GetElementType() !=
XFA_Element::Form &&
Wow, the conditionals just keep coming.

https://codereview.chromium.org/2082573007/diff/1/xfa/fxfa/parser/xfa_layout_...
xfa/fxfa/parser/xfa_layout_itemlayout.cpp:2500: goto SuspendAndCreateNewRow;
Gah!

https://codereview.chromium.org/2082573007/diff/1/xfa/fxfa/parser/xfa_object.h
File xfa/fxfa/parser/xfa_object.h (right):

https://codereview.chromium.org/2082573007/diff/1/xfa/fxfa/parser/xfa_object....
xfa/fxfa/parser/xfa_object.h:106: XFA_Element m_elementType;
const?

[Lei Zhang, 2016-06-23 05:04:26]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-06-23 05:04:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2082573007/1

[commit-bot: I haz the power, 2016-06-23 05:04:57]

Description was changed from

==========
Update GetClassID to GetElementType

The GetClassID method actually returns the XFA_Element, change the name of the
method to be more suggestive of the return value.

The GetClassID was sort-of polymorphich and would call down to subclasses. This
CL changes the data to be stored on the CXFA_Object class and just returns what
is set. The values are set in the constructor as needed.
==========

to

==========
Update GetClassID to GetElementType

The GetClassID method actually returns the XFA_Element, change the name of the
method to be more suggestive of the return value.

The GetClassID was sort-of polymorphich and would call down to subclasses. This
CL changes the data to be stored on the CXFA_Object class and just returns what
is set. The values are set in the constructor as needed.

Committed:
https://pdfium.googlesource.com/pdfium/+/070fcdfeafb17a9d3ada1418f48fd7f19aa4...
==========

[commit-bot: I haz the power, 2016-06-23 05:04:58]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/070fcdfeafb17a9d3ada1418f48fd7f19aa4...