Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Issue 2088173003: Remove unused GetScriptObjHash(). (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove unused GetScriptObjHash(). Method is never called, remove it and the data variable it uses as it will no longer be used. Committed: https://pdfium.googlesource.com/pdfium/+/a5ab26b8aa9ed12af8bdf323cb297f61cbfeb1fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M xfa/fxfa/parser/xfa_object.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_datawindow.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_eventpseudomodel.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_layoutpseudomodel.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_logpseudomodel.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_signaturepseudomodel.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-06-22 17:15:58 UTC) #2
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-23 04:08:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088173003/1
4 years, 6 months ago (2016-06-23 04:08:57 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 04:09:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/a5ab26b8aa9ed12af8bdf323cb297f61cbfe...

Powered by Google App Engine
This is Rietveld 408576698