xfa/fxfa/parser/xfa_document_imp.cpp - Issue 2082573007: Update GetClassID to GetElementType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/xfa_document_imp.cpp

Issue 2082573007: Update GetClassID to GetElementType (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@remove_script_obj_hash

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/parser/xfa_document_imp.cpp

diff --git a/xfa/fxfa/parser/xfa_document_imp.cpp b/xfa/fxfa/parser/xfa_document_imp.cpp

index 919a94d8fefae8f56f4dbd5c5c3fc37a9d7b9cb2..45102c8fb64fc22f49c872faf09337ccfe90cf13 100644

--- a/xfa/fxfa/parser/xfa_document_imp.cpp

+++ b/xfa/fxfa/parser/xfa_document_imp.cpp

@@ -290,7 +290,7 @@ static void XFA_ProtoMerge_MergeNodeRecurse(CXFA_Document* pDocument,

pDestNodeParent->GetNodeItem(XFA_NODEITEM_FirstChild);

pFormChild;

pFormChild = pFormChild->GetNodeItem(XFA_NODEITEM_NextSibling)) {

- if (pFormChild->GetClassID() == pProtoNode->GetClassID() &&

+ if (pFormChild->GetElementType() == pProtoNode->GetElementType() &&

pFormChild->GetNameHash() == pProtoNode->GetNameHash() &&

pFormChild->IsUnusedNode()) {

pFormChild->ClearFlag(XFA_NodeFlag_UnusedNode);