Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2082343003: Remove CXFA_OrdinaryObject class (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa_part_II
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove CXFA_OrdinaryObject class The CXFA_OrdinaryObject class no longer has any functionality but is just wraps CXFA_Object and sets the object type for the sub classes. This Cl removes the class and has the subclass set the object type themselves. This CL also renames the OrdinaryObject type to just Object. Committed: https://pdfium.googlesource.com/pdfium/+/937a11304dbf7abd97b76da8154e2b3bf5141aeb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -52 lines) Patch
M xfa/fxfa/parser/xfa_basic_data.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M xfa/fxfa/parser/xfa_object.h View 6 chunks +3 lines, -20 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_datawindow.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_datawindow.cpp View 1 chunk +10 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_eventpseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_eventpseudomodel.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_layoutpseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_layoutpseudomodel.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_logpseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_logpseudomodel.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_signaturepseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_signaturepseudomodel.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-06-22 18:17:01 UTC) #2
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-23 14:51:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082343003/1
4 years, 6 months ago (2016-06-23 14:51:48 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 14:52:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/937a11304dbf7abd97b76da8154e2b3bf514...

Powered by Google App Engine
This is Rietveld 408576698