Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2081813002: The disable_seamless_cube_map workaround should only apply to primary Intel. (Closed)

Created:
4 years, 6 months ago by Zhenyao Mo
Modified:
4 years, 6 months ago
Reviewers:
bajones
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The disable_seamless_cube_map workaround should only apply to primary Intel. On Mac retina where Intel is integrated and AMD/NVIDIA is discrete and is what is used for WebGL, this workaround should not apply. (This only affects WebGL2 on mac, so skip general try/cq bots) BUG=606074, 597794 TEST=mac gpu bots R=bajones@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/60714ca531b4b2f90ceed1a69ec44e0847998694 Cr-Commit-Position: refs/heads/master@{#401344}

Patch Set 1 #

Patch Set 2 : The disable_seamless_cube_map workaround should only apply to primary Intel. #

Patch Set 3 : The disable_seamless_cube_map workaround should only apply to primary Intel. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 2 chunks +7 lines, -6 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
Zhenyao Mo
bajones: PTAL
4 years, 6 months ago (2016-06-20 21:57:35 UTC) #3
bajones
On 2016/06/20 21:57:35, Zhenyao Mo wrote: > bajones: PTAL LGTM
4 years, 6 months ago (2016-06-20 21:58:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081813002/40001
4 years, 6 months ago (2016-06-22 17:56:33 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-22 18:10:21 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 18:17:00 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/60714ca531b4b2f90ceed1a69ec44e0847998694
Cr-Commit-Position: refs/heads/master@{#401344}

Powered by Google App Engine
This is Rietveld 408576698