Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 208133003: [CSS Grid Layout] Prevent issues with checkLayout() in grid items (Closed)

Created:
6 years, 9 months ago by Manuel Rego
Modified:
6 years, 9 months ago
CC:
blink-reviews, svillar, jfernandez, Manuel Rego
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Grid Layout] Prevent issues with checkLayout() in grid items When we use checkLayout() on a grid item, the results (PASS or FAIL messages) are added as new auto-placed items in the grid. This causes that the grid is marked as dirty which could hide bugs in the tests. Modify the related layout tests to use a different container for the test results. Updated expectations accordingly. There is one test missing "grid-item-addition-auto-placement-update.html". Which will be modified in the patch to fix the bug in RenderGrid::addChild() (see https://codereview.chromium.org/198703004/). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -43 lines) Patch
M LayoutTests/fast/css-grid-layout/grid-auto-columns-rows-update.html View 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-auto-columns-rows-update-expected.txt View 3 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-dynamic-updates-relayout.html View 2 chunks +4 lines, -1 line 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-dynamic-updates-relayout-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-removal-auto-placement-update.html View 2 chunks +8 lines, -5 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-removal-auto-placement-update-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-removal-track-breadth-update.html View 3 chunks +6 lines, -3 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-removal-track-breadth-update-expected.txt View 1 chunk +21 lines, -21 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html View 2 chunks +3 lines, -1 line 0 comments Download
M LayoutTests/fast/css-grid-layout/implicit-position-dynamic-change.html View 2 chunks +3 lines, -1 line 0 comments Download
M LayoutTests/fast/css-grid-layout/implicit-position-dynamic-change-expected.txt View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Manuel Rego
6 years, 9 months ago (2014-03-21 12:56:24 UTC) #1
Julien - ping for review
lgtm
6 years, 9 months ago (2014-03-21 18:02:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/208133003/1
6 years, 9 months ago (2014-03-21 18:02:55 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 18:56:02 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-21 18:56:02 UTC) #5
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 9 months ago (2014-03-21 19:26:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/208133003/1
6 years, 9 months ago (2014-03-21 19:26:23 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 19:28:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-21 19:28:39 UTC) #9
Manuel Rego
The CQ bit was checked by rego@igalia.com
6 years, 9 months ago (2014-03-21 22:34:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/208133003/1
6 years, 9 months ago (2014-03-21 22:34:54 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-22 04:14:22 UTC) #12
Message was sent while issue was closed.
Change committed as 169777

Powered by Google App Engine
This is Rietveld 408576698