LayoutTests/fast/css-grid-layout/implicit-position-dynamic-change.html - Issue 208133003: [CSS Grid Layout] Prevent issues with checkLayout() in grid items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/implicit-position-dynamic-change.html

Issue 208133003: [CSS Grid Layout] Prevent issues with checkLayout() in grid items (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html ('k') | LayoutTests/fast/css-grid-layout/implicit-position-dynamic-change-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/implicit-position-dynamic-change.html

diff --git a/LayoutTests/fast/css-grid-layout/implicit-position-dynamic-change.html b/LayoutTests/fast/css-grid-layout/implicit-position-dynamic-change.html

index 1e55c5b1b4979ed0c2d4ebd5199a022e530e997d..16b27cf2b1107db3a4a9fd9a2af0d75f9942a566 100644

--- a/LayoutTests/fast/css-grid-layout/implicit-position-dynamic-change.html

+++ b/LayoutTests/fast/css-grid-layout/implicit-position-dynamic-change.html

@@ -16,7 +16,7 @@ function testPosition(gridElementID, position, size)

gridItem.style.gridRow = position.row;

gridItem.setAttribute("data-expected-width", size.width);

gridItem.setAttribute("data-expected-height", size.height);

- checkLayout("#" + gridElementID);

+ checkLayout("#" + gridElementID, document.getElementById("test-output"));

}

function updateImplicitGridColumn()

@@ -121,5 +121,7 @@ window.addEventListener("load", updateImplicitGridColumn, false);

<div class="grid gridFixedContent" id="unconstrainedGrid"><div class="sizedToGridArea">XXXXXX XXXXXX</div></div>

</div>

+<div id="test-output"></div>

</body>

</html>