LayoutTests/fast/css-grid-layout/grid-item-removal-track-breadth-update.html - Issue 208133003: [CSS Grid Layout] Prevent issues with checkLayout() in grid items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/grid-item-removal-track-breadth-update.html

Issue 208133003: [CSS Grid Layout] Prevent issues with checkLayout() in grid items (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-item-removal-auto-placement-update-expected.txt ('k') | LayoutTests/fast/css-grid-layout/grid-item-removal-track-breadth-update-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/grid-item-removal-track-breadth-update.html

diff --git a/LayoutTests/fast/css-grid-layout/grid-item-removal-track-breadth-update.html b/LayoutTests/fast/css-grid-layout/grid-item-removal-track-breadth-update.html

index bac802bf0317f281210a91c41ec47884b86263d8..c5732768a542978662e1c1b24c857ad5222eb6b2 100644

--- a/LayoutTests/fast/css-grid-layout/grid-item-removal-track-breadth-update.html

+++ b/LayoutTests/fast/css-grid-layout/grid-item-removal-track-breadth-update.html

@@ -43,6 +43,7 @@

function testRemoval(gridElementID, size1, size2, size3)

{

+ var testOutput = document.getElementById("test-output");

var gridElement = document.getElementById(gridElementID);

var gridItem1 = gridElement.firstChild.nextSibling;

var gridItem2 = gridItem1.nextSibling.nextSibling;

@@ -53,19 +54,19 @@ function testRemoval(gridElementID, size1, size2, size3)

gridItem2.setAttribute("data-expected-height", size1.height);

gridItem3.setAttribute("data-expected-width", size1.width);

gridItem3.setAttribute("data-expected-height", size1.height);

- checkLayout("#" + gridElementID);

+ checkLayout("#" + gridElementID, testOutput);

gridElement.removeChild(gridItem1);

gridItem2.setAttribute("data-expected-width", size2.width);

gridItem2.setAttribute("data-expected-height", size2.height);

gridItem3.setAttribute("data-expected-width", size2.width);

gridItem3.setAttribute("data-expected-height", size2.height);

- checkLayout("#" + gridElementID);

+ checkLayout("#" + gridElementID, testOutput);

gridElement.removeChild(gridItem2);

gridItem3.setAttribute("data-expected-width", size3.width);

gridItem3.setAttribute("data-expected-height", size3.height);

- checkLayout("#" + gridElementID);

+ checkLayout("#" + gridElementID, testOutput);

}

function testRemovals()

@@ -279,5 +280,7 @@ window.addEventListener("load", testRemovals, false);

</div>

+<div id="test-output"></div>

</body>

</html>