Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2077523002:
Add contentWindow attribute for <object> elements. (Closed)
|
Created:
4 years, 6 months ago by Shanmuga Pandi Modified:
4 years, 6 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd contentWindow attribute for <object> elements
Firefox supporting contentWindow attribute for <object>
element.
BUG=601771
Committed: https://crrev.com/cc526ef25f0b6d2a819700ccbeac2b3acf6fab80
Cr-Commit-Position: refs/heads/master@{#401302}
Patch Set 1 #
Total comments: 9
Patch Set 2 : rebased #Patch Set 3 : Align with review comments #Patch Set 4 : Fixed failed test cases #
Total comments: 5
Patch Set 5 : Align with review comments #
Total comments: 21
Patch Set 6 : Align with review comments #Messages
Total messages: 53 (21 generated)
shanmuga.m@samsung.com changed reviewers: + haraken@chromium.org, philipj@opera.com, yukishiino@chromium.org
Description was changed from ========== Add contentWindow attributes for <object> elements. BUG=601771 ========== to ========== Add contentWindow attribute for <object> elements. BUG=601771 ==========
PTAL!! Thanks
The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077523002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
Did you send an Intent-to-ship to blink-dev@?
On 2016/06/16 12:09:00, haraken wrote: > Did you send an Intent-to-ship to blink-dev@? No. Have not sent!!
On 2016/06/16 12:10:07, Shanmuga Pandi wrote: > On 2016/06/16 12:09:00, haraken wrote: > > Did you send an Intent-to-ship to blink-dev@? > > No. Have not sent!! FYI .. There are some discussion in this on this url. https://codereview.chromium.org/1889993004
https://codereview.chromium.org/2077523002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html (right): https://codereview.chromium.org/2077523002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:9: var t1 = async_test("Test content window"); Why do you need to test asynchronously? https://codereview.chromium.org/2077523002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:10: function on_load () { I'd recommend to follow this style guide for JavaScript. https://google.github.io/styleguide/javascriptguide.xml onLoad() is preferable. https://codereview.chromium.org/2077523002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:13: assert_equals(contentWindow.TEST, true, "content window and attributes should be accessible"); Better to compare with an unique string so that we don't pass the test accidentally or coincidentally. https://codereview.chromium.org/2077523002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/html/HTMLObjectElement.idl (right): https://codereview.chromium.org/2077523002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/html/HTMLObjectElement.idl:37: readonly attribute WindowProxy? contentWindow; Do we really support "WindowProxy"? I don't see any other place that use WindowProxy. For example, HTMLIFrameElement.idl writes "Window?" instead of "WindowProxy?". I know that the spec says it's WindowProxy, but I'm not sure if Blink really supports it or not.
On 2016/06/16 12:24:23, Yuki wrote: > https://codereview.chromium.org/2077523002/diff/1/third_party/WebKit/LayoutTe... > File > third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html > (right): > > https://codereview.chromium.org/2077523002/diff/1/third_party/WebKit/LayoutTe... > third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:9: > var t1 = async_test("Test content window"); > Why do you need to test asynchronously? > > https://codereview.chromium.org/2077523002/diff/1/third_party/WebKit/LayoutTe... > third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:10: > function on_load () { > I'd recommend to follow this style guide for JavaScript. > https://google.github.io/styleguide/javascriptguide.xml > > onLoad() is preferable. > > https://codereview.chromium.org/2077523002/diff/1/third_party/WebKit/LayoutTe... > third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:13: > assert_equals(contentWindow.TEST, true, "content window and attributes should be > accessible"); > Better to compare with an unique string so that we don't pass the test > accidentally or coincidentally. > > https://codereview.chromium.org/2077523002/diff/1/third_party/WebKit/Source/c... > File third_party/WebKit/Source/core/html/HTMLObjectElement.idl (right): > > https://codereview.chromium.org/2077523002/diff/1/third_party/WebKit/Source/c... > third_party/WebKit/Source/core/html/HTMLObjectElement.idl:37: readonly attribute > WindowProxy? contentWindow; > Do we really support "WindowProxy"? > > I don't see any other place that use WindowProxy. For example, > HTMLIFrameElement.idl writes "Window?" instead of "WindowProxy?". > > I know that the spec says it's WindowProxy, but I'm not sure if Blink really > supports it or not. Thanks for the comments!! I will update the code!!
Please check this!! Thank you https://codereview.chromium.org/2077523002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html (right): https://codereview.chromium.org/2077523002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:9: var t1 = async_test("Test content window"); On 2016/06/16 12:24:23, Yuki wrote: > Why do you need to test asynchronously? This test need to be executed as async_test, else timed out occurs https://codereview.chromium.org/2077523002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:10: function on_load () { On 2016/06/16 12:24:23, Yuki wrote: > I'd recommend to follow this style guide for JavaScript. > https://google.github.io/styleguide/javascriptguide.xml > > onLoad() is preferable. Done. https://codereview.chromium.org/2077523002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:13: assert_equals(contentWindow.TEST, true, "content window and attributes should be accessible"); On 2016/06/16 12:24:23, Yuki wrote: > Better to compare with an unique string so that we don't pass the test > accidentally or coincidentally. Done. https://codereview.chromium.org/2077523002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/html/HTMLObjectElement.idl (right): https://codereview.chromium.org/2077523002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/html/HTMLObjectElement.idl:37: readonly attribute WindowProxy? contentWindow; On 2016/06/16 12:24:23, Yuki wrote: > Do we really support "WindowProxy"? > > I don't see any other place that use WindowProxy. For example, > HTMLIFrameElement.idl writes "Window?" instead of "WindowProxy?". > > I know that the spec says it's WindowProxy, but I'm not sure if Blink really > supports it or not. Done.
The CQ bit was checked by shanmuga.m@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077523002/40001
The CQ bit was unchecked by shanmuga.m@samsung.com
https://codereview.chromium.org/2077523002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html (right): https://codereview.chromium.org/2077523002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:13: assert_equals(contentWindow.TEST, true, "content window and attributes should be accessible"); On 2016/06/17 10:37:31, Shanmuga Pandi wrote: > On 2016/06/16 12:24:23, Yuki wrote: > > Better to compare with an unique string so that we don't pass the test > > accidentally or coincidentally. > > Done. Seems not done. You're still comparing with |true|. https://codereview.chromium.org/2077523002/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes-expected.txt (right): https://codereview.chromium.org/2077523002/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes-expected.txt:2: FAIL object.contentWindow assert_equals: The contentWindow's name of the object element should be 'o1'. expected "o1" but got "o" Could you tell us why the test is failing after you support contentWindow? https://codereview.chromium.org/2077523002/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html (right): https://codereview.chromium.org/2077523002/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:13: assert_equals(contentWindow.ContentWindowAndAttribute, true, "content window and attributes should be accessible"); I'd suggest: s/ContentWindowAndAttribute/attrInContentWindow/
PTAL https://codereview.chromium.org/2077523002/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes-expected.txt (right): https://codereview.chromium.org/2077523002/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes-expected.txt:2: FAIL object.contentWindow assert_equals: The contentWindow's name of the object element should be 'o1'. expected "o1" but got "o" On 2016/06/20 04:24:15, Yuki wrote: > Could you tell us why the test is failing after you support contentWindow? Firefox also behaving same like this with <object> element. (contentWindow.name not changing based on "name" attribute change) And I could see the same behavior in chrome, even if I run the test with <frame> element. (contentWindow's name does not change , after changing value of "name" attribute). But works well in firefox. Please correct me if I am wrong. If it is expected that contentWindow's name should change , after changing value of "name" attribute for both <frame> and <object> element, I will make a separate patch for that. https://codereview.chromium.org/2077523002/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html (right): https://codereview.chromium.org/2077523002/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:13: assert_equals(contentWindow.ContentWindowAndAttribute, true, "content window and attributes should be accessible"); On 2016/06/20 04:24:15, Yuki wrote: > I'd suggest: > s/ContentWindowAndAttribute/attrInContentWindow/ Done.
LGTM. https://codereview.chromium.org/2077523002/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes-expected.txt (right): https://codereview.chromium.org/2077523002/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes-expected.txt:2: FAIL object.contentWindow assert_equals: The contentWindow's name of the object element should be 'o1'. expected "o1" but got "o" On 2016/06/21 06:51:38, Shanmuga Pandi wrote: > On 2016/06/20 04:24:15, Yuki wrote: > > Could you tell us why the test is failing after you support contentWindow? > > Firefox also behaving same like this with <object> element. (contentWindow.name > not changing based on "name" attribute change) > > And I could see the same behavior in chrome, even if I run the test with <frame> > element. (contentWindow's name does not change , after changing value of "name" > attribute). But works well in firefox. Please correct me if I am wrong. > > If it is expected that contentWindow's name should change , after changing value > of "name" attribute for both <frame> and <object> element, I will make a > separate patch for that. I see. I think it's okay as is for the time being.
The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077523002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shanmuga.m@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077523002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
shanmuga.m@samsung.com changed reviewers: + foolip@chromium.org - philipj@opera.com
@foolip, PTAL!!
shanmuga.m@samsung.com changed reviewers: + fs@opera.com
PTAL!!
Description was changed from ========== Add contentWindow attribute for <object> elements. BUG=601771 ========== to ========== Add contentWindow attribute for <object> elements BUG=601771 ==========
This LGTM with the following suggestions. You'll need an API OWNERs approval too (at least for the virtual/stable/webexposed bit). It'd also be good to extend the description to mention what other browsers support this. https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/svg/as-object/resources/svg-object-contentWindow.svg (right): https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/as-object/resources/svg-object-contentWindow.svg:1: <?xml version="1.0" encoding="utf-8"?> Not needed. https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/as-object/resources/svg-object-contentWindow.svg:2: <svg xmlns="http://www.w3.org/2000/svg" width="0" height="0"> No need to specify empty dimensions. https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/as-object/resources/svg-object-contentWindow.svg:3: <script type="text/javascript"> Don't need to specify 'type'. https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html (right): https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:1: <!DOCTYPE html> There's some overlap with imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes.html here, but that test won't run correctly because "blue.html" seems to be missing. (I'm also not sure it's entirely correct...) It seems this test would be better placed in fast/dom or something like that, and named HTMLObjectElement-contentWindow... or something like that. https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:3: <title>Test</title> Use a title that says something useful. Maybe "HTMLObjectElement.contentWindow with SVG document". (And with a proper title you don't need a description for async_test below.) https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:6: <body onload="onLoad()"> Could drop the <body> and just use "window.onload = ..." below instead I think. https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/html/HTMLObjectElement.idl (left): https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/core/html/HTMLObjectElement.idl:37: // TODO(foolip): readonly attribute WindowProxy? contentWindow; Maybe keep the/a TODO because of the WindowProxy<->Window discrepancy (see Window.idl)
LGTM % fs's nits and some more https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes-expected.txt (right): https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes-expected.txt:2: FAIL object.contentWindow assert_equals: The contentWindow's name of the object element should be 'o1'. expected "o1" but got "o" https://html.spec.whatwg.org/#the-object-element:attr-object-name-3 says "Whenever the name attribute is set, if the object element has a nested browsing context, its name must be changed to the new value. If the attribute is removed, if the object element has a browsing context, the browsing context name must be set to the empty string." In other words, it looks like we're still not per spec here. If there isn't already an issue for this, can you file one and then link it in https://docs.google.com/spreadsheets/d/1-xlh6co6QYC-KVof27sVxjA7yuUFvYcaul3vE... ? https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html (right): https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:2: <meta charset="utf-8"> Don't need the charset if the file is entirely US-ASCII, which it is. https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:6: <body onload="onLoad()"> On 2016/06/22 08:33:02, fs wrote: > Could drop the <body> and just use "window.onload = ..." below instead I think. Yep, it can be window.onload = t.step_func_done(function() { ... }); But I think it's the object loading that's the interesting bit here, so I suggest obj.onload instead. https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:7: <object id="obj" type="image/svg+xml" data="resources/svg-object-contentWindow.svg"></object> You can probably drop all the attributes except data. Then just do document.querySelector('object') below. https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:9: var t1 = async_test("Test content window"); There's just one test here. In any case, the structure async_test(function(t) { window.onload = ... }) should cut out the extra variables and methods that don't add anything.
Description was changed from ========== Add contentWindow attribute for <object> elements BUG=601771 ========== to ========== Add contentWindow attribute for <object> elements Firefox supporting contentWindow attribute for <object> element. BUG=601771 ==========
> In other words, it looks like we're still not per spec here. If there isn't already an issue for this, can you file one and then link it in https://docs.google.com/spreadsheets/d/1-xlh6co6QYC-KVof27sVxjA7yuUFvYcaul3vE... ? I will file a bug for this and link to it in some time. https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/svg/as-object/resources/svg-object-contentWindow.svg (right): https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/as-object/resources/svg-object-contentWindow.svg:1: <?xml version="1.0" encoding="utf-8"?> On 2016/06/22 08:33:02, fs wrote: > Not needed. Done. https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/as-object/resources/svg-object-contentWindow.svg:2: <svg xmlns="http://www.w3.org/2000/svg" width="0" height="0"> On 2016/06/22 08:33:02, fs wrote: > No need to specify empty dimensions. Done. https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/as-object/resources/svg-object-contentWindow.svg:3: <script type="text/javascript"> On 2016/06/22 08:33:02, fs wrote: > Don't need to specify 'type'. Done. https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html (right): https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:1: <!DOCTYPE html> On 2016/06/22 08:33:02, fs wrote: > There's some overlap with > imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes.html > here, but that test won't run correctly because "blue.html" seems to be missing. > (I'm also not sure it's entirely correct...) > > It seems this test would be better placed in fast/dom or something like that, > and named HTMLObjectElement-contentWindow... or something like that. Done. https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:2: <meta charset="utf-8"> On 2016/06/22 09:37:04, Philip Jägenstedt wrote: > Don't need the charset if the file is entirely US-ASCII, which it is. Done. https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:3: <title>Test</title> On 2016/06/22 08:33:02, fs wrote: > Use a title that says something useful. Maybe "HTMLObjectElement.contentWindow > with SVG document". (And with a proper title you don't need a description for > async_test below.) Done. https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:6: <body onload="onLoad()"> On 2016/06/22 08:33:02, fs wrote: > Could drop the <body> and just use "window.onload = ..." below instead I think. Done. https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html:9: var t1 = async_test("Test content window"); On 2016/06/22 09:37:04, Philip Jägenstedt wrote: > There's just one test here. In any case, the structure async_test(function(t) { > window.onload = ... }) should cut out the extra variables and methods that don't > add anything. Done. https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/html/HTMLObjectElement.idl (left): https://codereview.chromium.org/2077523002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/core/html/HTMLObjectElement.idl:37: // TODO(foolip): readonly attribute WindowProxy? contentWindow; On 2016/06/22 08:33:02, fs wrote: > Maybe keep the/a TODO because of the WindowProxy<->Window discrepancy (see > Window.idl) Done.
shanmuga.m@samsung.com changed reviewers: + tkent@chromium.org
Adding @tkent for API OWNERs approval for the virtual/stable/webexposed bit.
The CQ bit was checked by shanmuga.m@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077523002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by foolip@chromium.org
lgtm My lgtm should suffice :) Trying CQ.
The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com, yukishiino@chromium.org Link to the patchset: https://codereview.chromium.org/2077523002/#ps100001 (title: "Align with review comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077523002/100001
Message was sent while issue was closed.
Description was changed from ========== Add contentWindow attribute for <object> elements Firefox supporting contentWindow attribute for <object> element. BUG=601771 ========== to ========== Add contentWindow attribute for <object> elements Firefox supporting contentWindow attribute for <object> element. BUG=601771 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Add contentWindow attribute for <object> elements Firefox supporting contentWindow attribute for <object> element. BUG=601771 ========== to ========== Add contentWindow attribute for <object> elements Firefox supporting contentWindow attribute for <object> element. BUG=601771 Committed: https://crrev.com/cc526ef25f0b6d2a819700ccbeac2b3acf6fab80 Cr-Commit-Position: refs/heads/master@{#401302} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/cc526ef25f0b6d2a819700ccbeac2b3acf6fab80 Cr-Commit-Position: refs/heads/master@{#401302}
Message was sent while issue was closed.
I recommend to add a chromestatus.com entry for this. We may skip intent-to-ship. This is trivial.
Message was sent while issue was closed.
On 2016/06/22 21:07:32, tkent wrote: > I recommend to add a http://chromestatus.com entry for this. > We may skip intent-to-ship. This is trivial. Added entry https://www.chromestatus.com/features/5717662780882944 |
