third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes-expected.txt - Issue 2077523002: Add contentWindow attribute for <object> elements.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes-expected.txt

Issue 2077523002: Add contentWindow attribute for <object> elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed failed test cases Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/plugin-attributes-enumeration-expected.txt ('k') | third_party/WebKit/LayoutTests/svg/as-object/resources/svg-object-contentWindow.svg » ('j') | third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 This is a testharness.js-based test.	1 This is a testharness.js-based test.

2 FAIL object.contentWindow Cannot read property 'name' of undefined	2 FAIL object.contentWindow assert_equals: The contentWindow's name of the object element should be 'o1'. expected "o1" but got "o"
	Yuki 2016/06/20 04:24:15 Could you tell us why the test is failing after yo Could you tell us why the test is failing after you support contentWindow? Shanmuga Pandi 2016/06/21 06:51:38 Firefox also behaving same like this with <object> Show quoted text On 2016/06/20 04:24:15, Yuki wrote: > Could you tell us why the test is failing after you support contentWindow? Firefox also behaving same like this with <object> element. (contentWindow.name not changing based on "name" attribute change) And I could see the same behavior in chrome, even if I run the test with <frame> element. (contentWindow's name does not change , after changing value of "name" attribute). But works well in firefox. Please correct me if I am wrong. If it is expected that contentWindow's name should change , after changing value of "name" attribute for both <frame> and <object> element, I will make a separate patch for that. Yuki 2016/06/21 09:39:26 I see. I think it's okay as is for the time being Show quoted text On 2016/06/21 06:51:38, Shanmuga Pandi wrote: > On 2016/06/20 04:24:15, Yuki wrote: > > Could you tell us why the test is failing after you support contentWindow? > > Firefox also behaving same like this with <object> element. (contentWindow.name > not changing based on "name" attribute change) > > And I could see the same behavior in chrome, even if I run the test with <frame> > element. (contentWindow's name does not change , after changing value of "name" > attribute). But works well in firefox. Please correct me if I am wrong. > > If it is expected that contentWindow's name should change , after changing value > of "name" attribute for both <frame> and <object> element, I will make a > separate patch for that. I see. I think it's okay as is for the time being.
3 FAIL object.width assert_equals: The width should be 100px. expected "100px" but got "auto"	3 FAIL object.width assert_equals: The width should be 100px. expected "100px" but got "auto"

4 FAIL object.height assert_equals: The height should be 50px. expected "50px" but got "auto"	4 FAIL object.height assert_equals: The height should be 50px. expected "50px" but got "auto"

5 Harness: the test ran to completion.	5 Harness: the test ran to completion.

6	6

OLD	NEW