third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html - Issue 2077523002: Add contentWindow attribute for <object> elements.

Side by Side Diff: third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html

Issue 2077523002: Add contentWindow attribute for <object> elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Align with review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/svg/as-object/resources/svg-object-contentWindow.svg ('K') | « third_party/WebKit/LayoutTests/svg/as-object/resources/svg-object-contentWindow.svg ('k') | third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt » ('j') | third_party/WebKit/Source/core/html/HTMLObjectElement.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	fs 2016/06/22 08:33:02 There's some overlap with imported/wpt/html/semant There's some overlap with imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes.html here, but that test won't run correctly because "blue.html" seems to be missing. (I'm also not sure it's entirely correct...) It seems this test would be better placed in fast/dom or something like that, and named HTMLObjectElement-contentWindow... or something like that. Shanmuga Pandi 2016/06/22 10:27:32 Done. Show quoted text On 2016/06/22 08:33:02, fs wrote: > There's some overlap with > imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes.html > here, but that test won't run correctly because "blue.html" seems to be missing. > (I'm also not sure it's entirely correct...) > > It seems this test would be better placed in fast/dom or something like that, > and named HTMLObjectElement-contentWindow... or something like that. Done.
	2 <meta charset="utf-8">
	foolip 2016/06/22 09:37:04 Don't need the charset if the file is entirely US- Don't need the charset if the file is entirely US-ASCII, which it is. Shanmuga Pandi 2016/06/22 10:27:32 Done. Show quoted text On 2016/06/22 09:37:04, Philip Jägenstedt wrote: > Don't need the charset if the file is entirely US-ASCII, which it is. Done.
	3 <title>Test</title>
	fs 2016/06/22 08:33:02 Use a title that says something useful. Maybe "HTM Use a title that says something useful. Maybe "HTMLObjectElement.contentWindow with SVG document". (And with a proper title you don't need a description for async_test below.) Shanmuga Pandi 2016/06/22 10:27:32 Done. Show quoted text On 2016/06/22 08:33:02, fs wrote: > Use a title that says something useful. Maybe "HTMLObjectElement.contentWindow > with SVG document". (And with a proper title you don't need a description for > async_test below.) Done.
	4 <script src="../../resources/testharness.js"></script>

	5 <script src="../../resources/testharnessreport.js"></script>

	6 <body onload="onLoad()">
	fs 2016/06/22 08:33:02 Could drop the <body> and just use "window.onload Could drop the <body> and just use "window.onload = ..." below instead I think. foolip 2016/06/22 09:37:04 Yep, it can be window.onload = t.step_func_done(fu Show quoted text On 2016/06/22 08:33:02, fs wrote: > Could drop the <body> and just use "window.onload = ..." below instead I think. Yep, it can be window.onload = t.step_func_done(function() { ... }); But I think it's the object loading that's the interesting bit here, so I suggest obj.onload instead. Shanmuga Pandi 2016/06/22 10:27:32 Done. Show quoted text On 2016/06/22 08:33:02, fs wrote: > Could drop the <body> and just use "window.onload = ..." below instead I think. Done.
	7 <object id="obj" type="image/svg+xml" data="resources/svg-object-contentWindow.s vg"></object>
	foolip 2016/06/22 09:37:04 You can probably drop all the attributes except da You can probably drop all the attributes except data. Then just do document.querySelector('object') below.
	8 <script>

	9 var t1 = async_test("Test content window");
	foolip 2016/06/22 09:37:04 There's just one test here. In any case, the struc There's just one test here. In any case, the structure async_test(function(t) { window.onload = ... }) should cut out the extra variables and methods that don't add anything. Shanmuga Pandi 2016/06/22 10:27:32 Done. Show quoted text On 2016/06/22 09:37:04, Philip Jägenstedt wrote: > There's just one test here. In any case, the structure async_test(function(t) { > window.onload = ... }) should cut out the extra variables and methods that don't > add anything. Done.
	10 function onLoad () {

	11 t1.step(function() {

	12 var contentWindow = document.getElementById('obj').contentWindow;

	13 assert_equals(contentWindow.attrInContentWindow, "validAttr", "content win dow and attributes should be accessible");

	14 });

	15 t1.done()

	16 }

	17 </script>

	18 </body>

OLD	NEW