third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html - Issue 2077523002: Add contentWindow attribute for <object> elements.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html

Issue 2077523002: Add contentWindow attribute for <object> elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/as-object/resources/svg-object-contentWindow.svg ('k') | third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt » ('j') | third_party/WebKit/Source/core/html/HTMLObjectElement.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <meta charset="utf-8">

	3 <title>Test</title>

	4 <script src="../../resources/testharness.js"></script>

	5 <script src="../../resources/testharnessreport.js"></script>

	6 <body onload="on_load()">

	7 <object id="obj" type="image/svg+xml" data="resources/svg-object-contentWindow.s vg"></object>

	8 <script>

	9 var t1 = async_test("Test content window");
	Yuki 2016/06/16 12:24:23 Why do you need to test asynchronously? Why do you need to test asynchronously? Shanmuga Pandi 2016/06/17 10:37:31 This test need to be executed as async_test, else Show quoted text On 2016/06/16 12:24:23, Yuki wrote: > Why do you need to test asynchronously? This test need to be executed as async_test, else timed out occurs
	10 function on_load () {
	Yuki 2016/06/16 12:24:23 I'd recommend to follow this style guide for JavaS I'd recommend to follow this style guide for JavaScript. https://google.github.io/styleguide/javascriptguide.xml onLoad() is preferable. Shanmuga Pandi 2016/06/17 10:37:31 Done. Show quoted text On 2016/06/16 12:24:23, Yuki wrote: > I'd recommend to follow this style guide for JavaScript. > https://google.github.io/styleguide/javascriptguide.xml > > onLoad() is preferable. Done.
	11 t1.step(function() {

	12 var contentWindow = document.getElementById('obj').contentWindow;

	13 assert_equals(contentWindow.TEST, true, "content window and attributes sho uld be accessible");
	Yuki 2016/06/16 12:24:23 Better to compare with an unique string so that we Better to compare with an unique string so that we don't pass the test accidentally or coincidentally. Shanmuga Pandi 2016/06/17 10:37:31 Done. Show quoted text On 2016/06/16 12:24:23, Yuki wrote: > Better to compare with an unique string so that we don't pass the test > accidentally or coincidentally. Done. Yuki 2016/06/20 04:24:15 Seems not done. You're still comparing with \|true Show quoted text On 2016/06/17 10:37:31, Shanmuga Pandi wrote: > On 2016/06/16 12:24:23, Yuki wrote: > > Better to compare with an unique string so that we don't pass the test > > accidentally or coincidentally. > > Done. Seems not done. You're still comparing with \|true\|.
	14 });

	15 t1.done()

	16 }

	17 </script>

	18 </body>

	19

OLD	NEW