Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2077413005: Add "alpha" option to PaintWorklet (Closed)

Created:
4 years, 6 months ago by Gleb Lanbin
Modified:
4 years, 5 months ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-css, dshwang, jbroman, haraken, dglazkov+blink, Rik, apavlov+blink_chromium.org, darktears, blink-reviews, f(malita), Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This change adds "alpha" option to PaintWorklet. Usage example: registerPaint('foo', class { static get alpha() { return true; } paint() { } }); If true (default) the backdrop of the rendering context is transparent, if false the backdrop is opaque. css-houdini-drafts github issue: https://github.com/w3c/css-houdini-drafts/issues/220 BUG=578252 TEST=third_party/WebKit/LayoutTests/csspaint/background-image-alpha.html Committed: https://crrev.com/7f4335afc67aec5a50d7eb1285f12c04ec41f8cb Cr-Commit-Position: refs/heads/master@{#403967}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comments #

Total comments: 10

Patch Set 3 : fix comments #

Total comments: 6

Patch Set 4 : fix comments #

Patch Set 5 : resolve a merge conflict #

Patch Set 6 : set alpha to be true by default #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -15 lines) Patch
A third_party/WebKit/LayoutTests/csspaint/background-image-alpha.html View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/csspaint/background-image-alpha-expected.html View 1 2 3 1 chunk +41 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/csspaint/registerPaint.html View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/csspaint/registerPaint-expected.txt View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPaintImageGenerator.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPaintValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSPaintValue.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.h View 1 2 4 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.cpp View 1 2 3 1 chunk +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2DTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp View 1 2 3 4 5 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 39 (19 generated)
Gleb Lanbin
4 years, 6 months ago (2016-06-21 22:07:02 UTC) #5
haraken
https://codereview.chromium.org/2077413005/diff/20001/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp File third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp (right): https://codereview.chromium.org/2077413005/diff/20001/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp#newcode100 third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp:100: bool hasAlphaChannel = alphaValue->IsBoolean() && v8::Local<v8::Boolean>::Cast(alphaValue)->Value(); Drive-by: 'alphaValue->IsBoolean() &&' ...
4 years, 6 months ago (2016-06-22 00:59:47 UTC) #7
Gleb Lanbin
https://codereview.chromium.org/2077413005/diff/20001/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp File third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp (right): https://codereview.chromium.org/2077413005/diff/20001/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp#newcode100 third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp:100: bool hasAlphaChannel = alphaValue->IsBoolean() && v8::Local<v8::Boolean>::Cast(alphaValue)->Value(); On 2016/06/22 00:59:47, ...
4 years, 6 months ago (2016-06-22 04:27:46 UTC) #8
ikilpatrick
+junov for canvas related changes. For testing that an occluded image doesn't load; have a ...
4 years, 6 months ago (2016-06-22 16:00:25 UTC) #10
ikilpatrick
+correct junov :)
4 years, 6 months ago (2016-06-22 16:01:19 UTC) #12
Gleb Lanbin
https://codereview.chromium.org/2077413005/diff/40001/third_party/WebKit/LayoutTests/csspaint/background-image-alpha.html File third_party/WebKit/LayoutTests/csspaint/background-image-alpha.html (right): https://codereview.chromium.org/2077413005/diff/40001/third_party/WebKit/LayoutTests/csspaint/background-image-alpha.html#newcode1 third_party/WebKit/LayoutTests/csspaint/background-image-alpha.html:1: <!DOCTYPE html> On 2016/06/22 16:00:24, ikilpatrick wrote: > For ...
4 years, 6 months ago (2016-06-22 21:23:46 UTC) #13
ikilpatrick
lgtm Wait for junov for graphics + renderingContext related changes. +timloh for css/* changes. https://codereview.chromium.org/2077413005/diff/60001/third_party/WebKit/LayoutTests/csspaint/background-image-alpha.html ...
4 years, 6 months ago (2016-06-23 16:53:42 UTC) #15
Justin Novosad
https://codereview.chromium.org/2077413005/diff/60001/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp File third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp (right): https://codereview.chromium.org/2077413005/diff/60001/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp#newcode32 third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp:32: clear(); Previous uses of RecordingImageBufferSurface did not need this ...
4 years, 6 months ago (2016-06-23 19:22:35 UTC) #16
Timothy Loh
On 2016/06/23 16:53:42, ikilpatrick wrote: > +timloh for css/* changes. css/ lgtm
4 years, 6 months ago (2016-06-23 21:47:44 UTC) #17
Gleb Lanbin
https://codereview.chromium.org/2077413005/diff/60001/third_party/WebKit/LayoutTests/csspaint/background-image-alpha.html File third_party/WebKit/LayoutTests/csspaint/background-image-alpha.html (right): https://codereview.chromium.org/2077413005/diff/60001/third_party/WebKit/LayoutTests/csspaint/background-image-alpha.html#newcode1 third_party/WebKit/LayoutTests/csspaint/background-image-alpha.html:1: <!DOCTYPE html> On 2016/06/23 16:53:42, ikilpatrick wrote: > missing ...
4 years, 6 months ago (2016-06-23 22:26:03 UTC) #18
Gleb Lanbin
Justin, does this patch look good to you?
4 years, 5 months ago (2016-06-28 19:21:53 UTC) #20
Justin Novosad
On 2016/06/28 19:21:53, glebl wrote: > Justin, does this patch look good to you? Sorry ...
4 years, 5 months ago (2016-07-04 15:13:29 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2077413005/100001
4 years, 5 months ago (2016-07-06 16:33:30 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/257805)
4 years, 5 months ago (2016-07-06 17:46:18 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2077413005/120001
4 years, 5 months ago (2016-07-06 18:33:11 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/99182)
4 years, 5 months ago (2016-07-06 21:48:50 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2077413005/120001
4 years, 5 months ago (2016-07-06 21:50:40 UTC) #34
commit-bot: I haz the power
Committed patchset #6 (id:120001)
4 years, 5 months ago (2016-07-06 23:14:07 UTC) #36
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 23:14:34 UTC) #37
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 23:16:26 UTC) #39
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/7f4335afc67aec5a50d7eb1285f12c04ec41f8cb
Cr-Commit-Position: refs/heads/master@{#403967}

Powered by Google App Engine
This is Rietveld 408576698